Use glGetStringi to get extensions when available.

Use glGetStringi to get extensions when available.
Committed: https://code.google.com/p/skia/source/detail?r=7872

[bsalomon, 2013-02-26 19:56:37]

Use glGetStringi to get extensions when available.

[bsalomon, 2013-02-26 20:30:06]

Necessary but not sufficient to use core profiles.

[robertphillips, 2013-02-26 21:06:07]

lgtm + comment/name change suggestions

https://codereview.chromium.org/12328111/diff/2006/include/gpu/gl/GrGLExtensi...
File include/gpu/gl/GrGLExtensions.h (right):

https://codereview.chromium.org/12328111/diff/2006/include/gpu/gl/GrGLExtensi...
include/gpu/gl/GrGLExtensions.h:26: /**
Doesn't it expect getString to always be non-NULL and getIntegerv and getStringi
to be non-NULL w/ 3.0 or higher?

https://codereview.chromium.org/12328111/diff/2006/include/gpu/gl/GrGLExtensi...
include/gpu/gl/GrGLExtensions.h:33: GrGLGetStringiProc getStringi,
getIntegerv?

https://codereview.chromium.org/12328111/diff/2006/src/gpu/gl/GrGLExtensions.cpp
File src/gpu/gl/GrGLExtensions.cpp (right):

https://codereview.chromium.org/12328111/diff/2006/src/gpu/gl/GrGLExtensions....
src/gpu/gl/GrGLExtensions.cpp:14: GrGLGetStringiProc getStringi,
getIntegerv?

[Jvsquare, 2013-02-26 21:32:41]

lgtm + one comment

On 2013/02/26 21:06:07, robertphillips wrote:
> lgtm + comment/name change suggestions
> 
>
https://codereview.chromium.org/12328111/diff/2006/include/gpu/gl/GrGLExtensi...
> File include/gpu/gl/GrGLExtensions.h (right):
> 
>
https://codereview.chromium.org/12328111/diff/2006/include/gpu/gl/GrGLExtensi...
> include/gpu/gl/GrGLExtensions.h:26: /**
> Doesn't it expect getString to always be non-NULL and getIntegerv and
getStringi
> to be non-NULL w/ 3.0 or higher?
> 
>
https://codereview.chromium.org/12328111/diff/2006/include/gpu/gl/GrGLExtensi...
> include/gpu/gl/GrGLExtensions.h:33: GrGLGetStringiProc getStringi,
> getIntegerv?
> 
>
https://codereview.chromium.org/12328111/diff/2006/src/gpu/gl/GrGLExtensions.cpp
> File src/gpu/gl/GrGLExtensions.cpp (right):
> 
>
https://codereview.chromium.org/12328111/diff/2006/src/gpu/gl/GrGLExtensions....
> src/gpu/gl/GrGLExtensions.cpp:14: GrGLGetStringiProc getStringi,
> getIntegerv?

[bsalomon, 2013-02-26 21:32:51]

https://codereview.chromium.org/12328111/diff/2006/include/gpu/gl/GrGLExtensi...
File include/gpu/gl/GrGLExtensions.h (right):

https://codereview.chromium.org/12328111/diff/2006/include/gpu/gl/GrGLExtensi...
include/gpu/gl/GrGLExtensions.h:26: /**
On 2013/02/26 21:06:07, robertphillips wrote:
> Doesn't it expect getString to always be non-NULL and getIntegerv and
getStringi
> to be non-NULL w/ 3.0 or higher?

Hmm... I suppose that is true in the implementation, though getIntegerv should
always be available in practice... I'll update the comment.

https://codereview.chromium.org/12328111/diff/2006/include/gpu/gl/GrGLExtensi...
include/gpu/gl/GrGLExtensions.h:33: GrGLGetStringiProc getStringi,
On 2013/02/26 21:06:07, robertphillips wrote:
> getIntegerv?

Done.

https://codereview.chromium.org/12328111/diff/2006/src/gpu/gl/GrGLExtensions.cpp
File src/gpu/gl/GrGLExtensions.cpp (right):

https://codereview.chromium.org/12328111/diff/2006/src/gpu/gl/GrGLExtensions....
src/gpu/gl/GrGLExtensions.cpp:14: GrGLGetStringiProc getStringi,
On 2013/02/26 21:06:07, robertphillips wrote:
> getIntegerv?

Done.

[Jvsquare, 2013-02-26 21:33:38]

Let's try that again, shall we...?

https://codereview.chromium.org/12328111/diff/2006/src/gpu/gl/GrGLExtensions.cpp
File src/gpu/gl/GrGLExtensions.cpp (right):

https://codereview.chromium.org/12328111/diff/2006/src/gpu/gl/GrGLExtensions....
src/gpu/gl/GrGLExtensions.cpp:41: const char* extensions = (const char*)
getString(GR_GL_EXTENSIONS);
Not a huge deal since it's in an init function, but it'd be nice if this scanned
the extension string only once.

[bsalomon, 2013-02-26 21:38:45]

https://codereview.chromium.org/12328111/diff/2006/src/gpu/gl/GrGLExtensions.cpp
File src/gpu/gl/GrGLExtensions.cpp (right):

https://codereview.chromium.org/12328111/diff/2006/src/gpu/gl/GrGLExtensions....
src/gpu/gl/GrGLExtensions.cpp:41: const char* extensions = (const char*)
getString(GR_GL_EXTENSIONS);
On 2013/02/26 21:33:39, jvanverth wrote:
> Not a huge deal since it's in an init function, but it'd be nice if this
scanned
> the extension string only once.

True... I was thinking that the initial scan to get the size would be cheaper
than having multiple malloc calls while building the stretchy array. I suppose I
should at least comment on that.

[bsalomon, 2013-02-26 21:46:43]

Committed manually as r7872 (presubmit successful).