Expose distiller functions to JavaScript

Expose distiller functions to JavaScript

This change adds two mojo services; one for notifying a RenderFrame
that it is working on a distiller page and one for allowing distiller
JavaScript functions to access the browser. This CL only exposes a
single function "distiller.echo".

BUG=

Committed: https://crrev.com/c5fc07ec3016dc3fb0d58c6869f1fc9bedb8b3a7
Cr-Commit-Position: refs/heads/master@{#347951}

[mdjones, 2015-07-11 02:11:57]

mdjones@chromium.org changed reviewers:
+ cjhopman@chromium.org, nyquist@chromium.org

[mdjones, 2015-07-11 02:11:58]

Still working on the tests, but the rest can be reviewed if you have time while
I'm out next week. Thanks!

[mdjones, 2015-07-24 21:41:51]

On 2015/07/11 02:11:58, mdjones wrote:
> Still working on the tests, but the rest can be reviewed if you have time
while
> I'm out next week. Thanks!

Tests have been added.

[nyquist, 2015-07-27 21:44:34]

preliminary comments

https://codereview.chromium.org/1231083007/diff/100001/chrome/renderer/chrome...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/1231083007/diff/100001/chrome/renderer/chrome...
chrome/renderer/chrome_content_renderer_client.cc:563: new
dom_distiller::DistillerJsRenderFrameObserver(render_frame);
When is this deleted?

https://codereview.chromium.org/1231083007/diff/100001/components/dom_distill...
File
components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h
(right):

https://codereview.chromium.org/1231083007/diff/100001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h:27:
void RegisterMojoService();
How do these two methods below differ? Could you add some short comments?

https://codereview.chromium.org/1231083007/diff/100001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h:28:
void SetupMojoForJavaScript();
Why is this method public? Isn't it only called from DidStartProvisionalLoad() ?

https://codereview.chromium.org/1231083007/diff/100001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h:31:
void createDistillerPageNotifierService(
createDistillerPageNotifierService

https://codereview.chromium.org/1231083007/diff/100001/components/dom_distill...
File components/dom_distiller/content/renderer/distiller_native_javascript.h
(right):

https://codereview.chromium.org/1231083007/diff/100001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_native_javascript.h:30:
std::string distillerEcho(const std::string& message);
DistillerEcho

https://codereview.chromium.org/1231083007/diff/100001/components/dom_distill...
File
components/dom_distiller/content/renderer/distiller_page_notifier_service_impl.h
(right):

https://codereview.chromium.org/1231083007/diff/100001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_page_notifier_service_impl.h:16:
class DistillerPageNotifierServiceImpl
i can haz comment? What does this do? What is its responsibilities? When should
it be created / what lifecycle it tied to?

[mdjones, 2015-07-28 20:53:42]

Made some changes to the testing utils and added domAutomationController to
isolated worlds as they are created for testing purposes.

https://codereview.chromium.org/1231083007/diff/100001/chrome/renderer/chrome...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/1231083007/diff/100001/chrome/renderer/chrome...
chrome/renderer/chrome_content_renderer_client.cc:563: new
dom_distiller::DistillerJsRenderFrameObserver(render_frame);
On 2015/07/27 21:44:33, nyquist wrote:
> When is this deleted?

This is managed by the RenderFrame object. All the observers are destroyed when
the RenderFrame is.

https://codereview.chromium.org/1231083007/diff/100001/components/dom_distill...
File
components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h
(right):

https://codereview.chromium.org/1231083007/diff/100001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h:27:
void RegisterMojoService();
On 2015/07/27 21:44:33, nyquist wrote:
> How do these two methods below differ? Could you add some short comments?

One of the function names needed to be updated. Done.

https://codereview.chromium.org/1231083007/diff/100001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h:28:
void SetupMojoForJavaScript();
On 2015/07/27 21:44:33, nyquist wrote:
> Why is this method public? Isn't it only called from DidStartProvisionalLoad()
?

No, it is called by the DistillerPageNotifierImpl.

https://codereview.chromium.org/1231083007/diff/100001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h:31:
void createDistillerPageNotifierService(
On 2015/07/27 21:44:33, nyquist wrote:
> createDistillerPageNotifierService

That is what it currently is.

https://codereview.chromium.org/1231083007/diff/100001/components/dom_distill...
File components/dom_distiller/content/renderer/distiller_native_javascript.h
(right):

https://codereview.chromium.org/1231083007/diff/100001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_native_javascript.h:30:
std::string distillerEcho(const std::string& message);
On 2015/07/27 21:44:33, nyquist wrote:
> DistillerEcho

Done.

https://codereview.chromium.org/1231083007/diff/100001/components/dom_distill...
File
components/dom_distiller/content/renderer/distiller_page_notifier_service_impl.h
(right):

https://codereview.chromium.org/1231083007/diff/100001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_page_notifier_service_impl.h:16:
class DistillerPageNotifierServiceImpl
On 2015/07/27 21:44:33, nyquist wrote:
> i can haz comment? What does this do? What is its responsibilities? When
should
> it be created / what lifecycle it tied to?

The service is removed when the page is done loading. Done.

[cjhopman, 2015-07-29 00:26:51]

https://codereview.chromium.org/1231083007/diff/140001/components/dom_distill...
File
components/dom_distiller/content/browser/distillable_page_utils_browsertest.cc
(left):

https://codereview.chromium.org/1231083007/diff/140001/components/dom_distill...
components/dom_distiller/content/browser/distillable_page_utils_browsertest.cc:45:
embedded_test_server()->GetURL(url),
Can we remove all the unrelated style/formatting changes?

[mdjones, 2015-07-29 18:36:00]

https://codereview.chromium.org/1231083007/diff/140001/components/dom_distill...
File
components/dom_distiller/content/browser/distillable_page_utils_browsertest.cc
(left):

https://codereview.chromium.org/1231083007/diff/140001/components/dom_distill...
components/dom_distiller/content/browser/distillable_page_utils_browsertest.cc:45:
embedded_test_server()->GetURL(url),
On 2015/07/29 00:26:51, cjhopman wrote:
> Can we remove all the unrelated style/formatting changes?

Done.

[nyquist, 2015-08-11 08:11:55]

https://codereview.chromium.org/1231083007/diff/160001/components/dom_distill...
File
components/dom_distiller/content/common/distiller_page_notifier_service.mojom
(right):

https://codereview.chromium.org/1231083007/diff/160001/components/dom_distill...
components/dom_distiller/content/common/distiller_page_notifier_service.mojom:8:
Notify();
What does this notify?

https://codereview.chromium.org/1231083007/diff/160001/components/dom_distill...
File
components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h
(right):

https://codereview.chromium.org/1231083007/diff/160001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h:37:
void createDistillerPageNotifierService(
Create*

https://codereview.chromium.org/1231083007/diff/160001/components/dom_distill...
File components/dom_distiller/content/renderer/distiller_native_javascript.h
(right):

https://codereview.chromium.org/1231083007/diff/160001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_native_javascript.h:20:
DistillerNativeJavaScript(content::RenderFrame* render_frame);
explicit

https://codereview.chromium.org/1231083007/diff/160001/components/dom_distill...
File
components/dom_distiller/content/renderer/distiller_page_notifier_service_impl.h
(right):

https://codereview.chromium.org/1231083007/diff/160001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_page_notifier_service_impl.h:23:
DistillerPageNotifierServiceImpl(DistillerJsRenderFrameObserver* observer);
single-argument constructors should be explicit.

https://codereview.chromium.org/1231083007/diff/160001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_page_notifier_service_impl.h:24:
void Notify() override;
Add a comment that his method is the implementation of the interface..

https://codereview.chromium.org/1231083007/diff/160001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_page_notifier_service_impl.h:25:
~DistillerPageNotifierServiceImpl() override;
Goes together with the constructor.

[mdjones, 2015-08-11 16:02:05]

https://codereview.chromium.org/1231083007/diff/160001/components/dom_distill...
File
components/dom_distiller/content/common/distiller_page_notifier_service.mojom
(right):

https://codereview.chromium.org/1231083007/diff/160001/components/dom_distill...
components/dom_distiller/content/common/distiller_page_notifier_service.mojom:8:
Notify();
On 2015/08/11 08:11:55, nyquist wrote:
> What does this notify?

Done.

https://codereview.chromium.org/1231083007/diff/160001/components/dom_distill...
File
components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h
(right):

https://codereview.chromium.org/1231083007/diff/160001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h:37:
void createDistillerPageNotifierService(
On 2015/08/11 08:11:55, nyquist wrote:
> Create*

Done.

https://codereview.chromium.org/1231083007/diff/160001/components/dom_distill...
File components/dom_distiller/content/renderer/distiller_native_javascript.h
(right):

https://codereview.chromium.org/1231083007/diff/160001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_native_javascript.h:20:
DistillerNativeJavaScript(content::RenderFrame* render_frame);
On 2015/08/11 08:11:55, nyquist wrote:
> explicit

Done.

https://codereview.chromium.org/1231083007/diff/160001/components/dom_distill...
File
components/dom_distiller/content/renderer/distiller_page_notifier_service_impl.h
(right):

https://codereview.chromium.org/1231083007/diff/160001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_page_notifier_service_impl.h:23:
DistillerPageNotifierServiceImpl(DistillerJsRenderFrameObserver* observer);
On 2015/08/11 08:11:55, nyquist wrote:
> single-argument constructors should be explicit.

Done.

https://codereview.chromium.org/1231083007/diff/160001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_page_notifier_service_impl.h:24:
void Notify() override;
On 2015/08/11 08:11:55, nyquist wrote:
> Add a comment that his method is the implementation of the interface..

Done.

https://codereview.chromium.org/1231083007/diff/160001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_page_notifier_service_impl.h:25:
~DistillerPageNotifierServiceImpl() override;
On 2015/08/11 08:11:55, nyquist wrote:
> Goes together with the constructor.

Done.

[nyquist, 2015-08-19 10:59:54]

Just a few style-comments and comments about comments... Otherwise lgtm!

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
File components/dom_distiller.gypi (right):

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
components/dom_distiller.gypi:196: 'dom_distiller_core',
Local deps first, then lexicographical sort.

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
components/dom_distiller.gypi:234: '../content/content.gyp:content_browser',
Lexicographical sort

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
components/dom_distiller.gypi:239: 'dom_distiller_mojo_bindings',
Local deps first.

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
File
components/dom_distiller/content/browser/distiller_javascript_service_impl.h
(right):

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
components/dom_distiller/content/browser/distiller_javascript_service_impl.h:18:
void HandleDistillerEchoCall(const mojo::String& message) override;
Could you add a comment about what this implements?

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
components/dom_distiller/content/browser/distiller_javascript_service_impl.h:19:
~DistillerJavaScriptServiceImpl() override;
Move after constructor.

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
File components/dom_distiller/content/common/distiller_javascript_service.mojom
(right):

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
components/dom_distiller/content/common/distiller_javascript_service.mojom:7:
interface DistillerJavaScriptService {
It would be helpful with a short description saying which end of the service
this is in. Is this running in the context of the renderer? Or in the browser
process?

The direction of these mojo-service seems to confuse me every time I look at
these services, and I guess a quick comment here would help me get my bearings
right (same for the other .mojom file).

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
File
components/dom_distiller/content/renderer/distiller_js_render_frame_observer.cc
(right):

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_js_render_frame_observer.cc:49:
DistillerJsRenderFrameObserver::~DistillerJsRenderFrameObserver() {}
Could this also live with the constructor?

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
File
components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h
(right):

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h:19:
class DistillerJsRenderFrameObserver : public content::RenderFrameObserver {
What is this class for?
In general, please add a top-level comment to all classes. Future Matt will like
you better.

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h:29:
~DistillerJsRenderFrameObserver() override;
Move to after constructor

https://codereview.chromium.org/1231083007/diff/180001/content/public/test/br...
File content/public/test/browser_test_utils.h (right):

https://codereview.chromium.org/1231083007/diff/180001/content/public/test/br...
content/public/test/browser_test_utils.h:193: bool
ExecuteScriptInIsolatedWorldAndExtractBool(
Should this be listed below the non-isolated world ones? Also; should this have
an extra comment about the isolated world stuff?

[mdjones, 2015-08-19 20:25:18]

mdjones@chromium.org changed reviewers:
+ jochen@chromium.org

[mdjones, 2015-08-19 20:25:20]

+jochen for chrome and content changes.

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
File components/dom_distiller.gypi (right):

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
components/dom_distiller.gypi:196: 'dom_distiller_core',
On 2015/08/19 10:59:54, nyquist (OOO - back 8-24) wrote:
> Local deps first, then lexicographical sort.

Done.

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
components/dom_distiller.gypi:234: '../content/content.gyp:content_browser',
On 2015/08/19 10:59:54, nyquist (OOO - back 8-24) wrote:
> Lexicographical sort

Done.

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
components/dom_distiller.gypi:239: 'dom_distiller_mojo_bindings',
On 2015/08/19 10:59:54, nyquist (OOO - back 8-24) wrote:
> Local deps first.

Done.

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
File
components/dom_distiller/content/browser/distiller_javascript_service_impl.h
(right):

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
components/dom_distiller/content/browser/distiller_javascript_service_impl.h:18:
void HandleDistillerEchoCall(const mojo::String& message) override;
On 2015/08/19 10:59:54, nyquist (OOO - back 8-24) wrote:
> Could you add a comment about what this implements?

Done.

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
components/dom_distiller/content/browser/distiller_javascript_service_impl.h:19:
~DistillerJavaScriptServiceImpl() override;
On 2015/08/19 10:59:54, nyquist (OOO - back 8-24) wrote:
> Move after constructor.

Done.

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
File components/dom_distiller/content/common/distiller_javascript_service.mojom
(right):

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
components/dom_distiller/content/common/distiller_javascript_service.mojom:7:
interface DistillerJavaScriptService {
On 2015/08/19 10:59:54, nyquist (OOO - back 8-24) wrote:
> It would be helpful with a short description saying which end of the service
> this is in. Is this running in the context of the renderer? Or in the browser
> process?
> 
> The direction of these mojo-service seems to confuse me every time I look at
> these services, and I guess a quick comment here would help me get my bearings
> right (same for the other .mojom file).

Done.

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
File
components/dom_distiller/content/renderer/distiller_js_render_frame_observer.cc
(right):

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_js_render_frame_observer.cc:49:
DistillerJsRenderFrameObserver::~DistillerJsRenderFrameObserver() {}
On 2015/08/19 10:59:54, nyquist (OOO - back 8-24) wrote:
> Could this also live with the constructor?

Done.

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
File
components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h
(right):

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h:19:
class DistillerJsRenderFrameObserver : public content::RenderFrameObserver {
On 2015/08/19 10:59:54, nyquist (OOO - back 8-24) wrote:
> What is this class for?
> In general, please add a top-level comment to all classes. Future Matt will
like
> you better.

Done.

https://codereview.chromium.org/1231083007/diff/180001/components/dom_distill...
components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h:29:
~DistillerJsRenderFrameObserver() override;
On 2015/08/19 10:59:54, nyquist (OOO - back 8-24) wrote:
> Move to after constructor

Done.

[mdjones, 2015-09-01 15:33:32]

mdjones@chromium.org changed reviewers:
+ nasko@chromium.org

[mdjones, 2015-09-01 15:33:32]

+nasko Could you please take a look at the content/chrome changes since jochen
is ooo?

[nasko, 2015-09-02 21:59:40]

I'm not the right reviewer for GIN or V8 related code. A drive-by comment
though.

https://codereview.chromium.org/1231083007/diff/220001/content/public/test/br...
File content/public/test/browser_test_utils.cc (right):

https://codereview.chromium.org/1231083007/diff/220001/content/public/test/br...
content/public/test/browser_test_utils.cc:171: WARN_UNUSED_RESULT;
Why not just add this on the method itself? Why do we need a prototype?

[mdjones, 2015-09-03 01:38:29]

https://codereview.chromium.org/1231083007/diff/220001/content/public/test/br...
File content/public/test/browser_test_utils.cc (right):

https://codereview.chromium.org/1231083007/diff/220001/content/public/test/br...
content/public/test/browser_test_utils.cc:171: WARN_UNUSED_RESULT;
On 2015/09/02 21:59:40, nasko (slow to review) wrote:
> Why not just add this on the method itself? Why do we need a prototype?

The compiler throws an error if that attribute is put on the method (though I
see it is used like this in other places outside this file). This follows the
pattern that "ExecuteScriptHelper" uses.

[jochen (gone - plz use gerrit), 2015-09-08 12:27:30]

https://codereview.chromium.org/1231083007/diff/240001/chrome/browser/BUILD.gn
File chrome/browser/BUILD.gn (right):

https://codereview.chromium.org/1231083007/diff/240001/chrome/browser/BUILD.g...
chrome/browser/BUILD.gn:280:
"//components/dom_distiller/content:content_renderer",
browser must not depend on renderer

https://codereview.chromium.org/1231083007/diff/240001/chrome/chrome_browser....
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/1231083007/diff/240001/chrome/chrome_browser....
chrome/chrome_browser.gypi:3240:
'../components/components.gyp:dom_distiller_content_renderer',
same here

https://codereview.chromium.org/1231083007/diff/240001/chrome/renderer/DEPS
File chrome/renderer/DEPS (right):

https://codereview.chromium.org/1231083007/diff/240001/chrome/renderer/DEPS#n...
chrome/renderer/DEPS:13: "+components/dom_distiller/content",
please add content/common and content/renderer explicitly, in case
content/browser is added at some point

[mdjones, 2015-09-08 16:32:32]

https://codereview.chromium.org/1231083007/diff/240001/chrome/browser/BUILD.gn
File chrome/browser/BUILD.gn (right):

https://codereview.chromium.org/1231083007/diff/240001/chrome/browser/BUILD.g...
chrome/browser/BUILD.gn:280:
"//components/dom_distiller/content:content_renderer",
On 2015/09/08 12:27:30, jochen wrote:
> browser must not depend on renderer

Moved to chrome/renderer/BUILD.gn

https://codereview.chromium.org/1231083007/diff/240001/chrome/chrome_browser....
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/1231083007/diff/240001/chrome/chrome_browser....
chrome/chrome_browser.gypi:3240:
'../components/components.gyp:dom_distiller_content_renderer',
On 2015/09/08 12:27:30, jochen wrote:
> same here

Moved to chrome/chrome_renderer.gypi

https://codereview.chromium.org/1231083007/diff/240001/chrome/renderer/DEPS
File chrome/renderer/DEPS (right):

https://codereview.chromium.org/1231083007/diff/240001/chrome/renderer/DEPS#n...
chrome/renderer/DEPS:13: "+components/dom_distiller/content",
On 2015/09/08 12:27:30, jochen wrote:
> please add content/common and content/renderer explicitly, in case
> content/browser is added at some point

Done.

[jochen (gone - plz use gerrit), 2015-09-09 14:35:22]

lgtm

[mdjones, 2015-09-09 15:27:32]

The CQ bit was checked by mdjones@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-09 15:27:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1231083007/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1231083007/260001

[commit-bot: I haz the power, 2015-09-09 16:51:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-09 16:51:43]

Dry run: This issue passed the CQ dry run.

[mdjones, 2015-09-09 17:05:46]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2015-09-09 17:05:47]

The patchset sent to the CQ was uploaded after l-g-t-m from nyquist@chromium.org
Link to the patchset: https://codereview.chromium.org/1231083007/#ps260001
(title: "Move dependencies to correct files")

[commit-bot: I haz the power, 2015-09-09 17:06:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1231083007/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1231083007/260001

[commit-bot: I haz the power, 2015-09-09 17:11:29]

Committed patchset #14 (id:260001)

[commit-bot: I haz the power, 2015-09-09 17:12:12]

Patchset 14 (id:??) landed as
https://crrev.com/c5fc07ec3016dc3fb0d58c6869f1fc9bedb8b3a7
Cr-Commit-Position: refs/heads/master@{#347951}

[stgao, 2015-09-09 21:02:28]

stgao@chromium.org changed reviewers:
+ stgao@chromium.org

[stgao, 2015-09-09 21:02:29]

FYI: This CL seems to cause compile failures on Win GN dbg bots.
https://findit-for-me.appspot.com/build-failure?url=https://build.chromium.or...
https://findit-for-me.appspot.com/build-failure?url=https://build.chromium.or...

added distiller_native_javascript.h (distiller_native_javascript.obj was in log)
added distiller_native_javascript.cc (distiller_native_javascript.obj was in
log)

[Dan Beam, 2015-09-10 02:22:09]

A revert of this CL (patchset #14 id:260001) has been created in
https://codereview.chromium.org/1336433002/ by dbeam@chromium.org.

The reason for reverting is: Broke GN compile

http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/...
http://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/build...

[569/575] LINK(DLL) chrome.dll chrome.dll.lib
FAILED: E:/b/depot_tools/python276_bin/python.exe gyp-win-tool link-wrapper
environment.x86 False link.exe /nologo /IMPLIB:./chrome.dll.lib /DLL
/OUT:./chrome.dll /PDB:./chrome.dll.pdb @./chrome.dll.rsp
content_renderer.lib(distiller_native_javascript.obj) : error LNK2005: "public:
static class v8::Object * __cdecl v8::Object::Cast(class v8::Value *)"
(?Cast@Object@v8@@SAPAV12@PAVValue@2@@Z) already defined in v8.dll.lib(v8.dll).

[commit-bot: I haz the power, 2015-09-23 12:00:44]

Patchset 14 (id:??) landed as
https://crrev.com/c5fc07ec3016dc3fb0d58c6869f1fc9bedb8b3a7
Cr-Commit-Position: refs/heads/master@{#347951}