Expose distiller functions to JavaScript

components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_DOM_DISTILLER_CONTENT_RENDERER_DISTILLER_JS_RENDER_FRAME_OBSERVER_H_
+#define COMPONENTS_DOM_DISTILLER_CONTENT_RENDERER_DISTILLER_JS_RENDER_FRAME_OBSERVER_H_
+
+#include "base/memory/weak_ptr.h"
+#include "components/dom_distiller/content/common/distiller_javascript_service.mojom.h"
+#include "components/dom_distiller/content/renderer/distiller_native_javascript.h"
+#include "components/dom_distiller/content/renderer/distiller_page_notifier_service_impl.h"
+#include "content/public/renderer/render_frame.h"
+#include "content/public/renderer/render_frame_observer.h"
+#include "third_party/WebKit/public/web/WebLocalFrame.h"
+#include "v8/include/v8.h"
+
+namespace dom_distiller {
+
+class DistillerJsRenderFrameObserver : public content::RenderFrameObserver {

[nyquist, 2015/08/19 10:59:54]

What is this class for?
In general, please add a top-level comment to all classes. Future Matt will like
you better.

[mdjones, 2015/08/19 20:25:19]

Done.

+ public:
+  DistillerJsRenderFrameObserver(content::RenderFrame* render_frame,
+                                 const int distiller_isolated_world_id);
+  // RenderFrameObserver implementation.
+  void DidStartProvisionalLoad() override;
+  void DidFinishLoad() override;
+  void DidCreateScriptContext(v8::Local<v8::Context> context,
+                              int extension_group,
+                              int world_id) override;
+  ~DistillerJsRenderFrameObserver() override;

[nyquist, 2015/08/19 10:59:54]

Move to after constructor

[mdjones, 2015/08/19 20:25:19]

Done.

+
+  // Add the mojo service to a RenderFrame's service registry.
+  void RegisterMojoService();
+  // Flag the current page as a distiller page.
+  void SetIsDistillerPage();
+
+ private:
+  void CreateDistillerPageNotifierService(
+      mojo::InterfaceRequest<DistillerPageNotifierService> request);
+
+  // The isolated world that the distiller object should be written to.
+  int distiller_isolated_world_id_;
+
+  // Track if the current page is distilled. This is needed for testing.
+  bool is_distiller_page_;
+
+  // Handle to "distiller" JavaScript object functionality.
+  scoped_ptr<DistillerNativeJavaScript> native_javascript_handle_;
+  base::WeakPtrFactory<DistillerJsRenderFrameObserver> weak_factory_;
+};
+
+}  // namespace dom_distiller
+
+#endif  // COMPONENTS_DOM_DISTILLER_CONTENT_RENDERER_DISTILLER_JS_RENDER_FRAME_OBSERVER_H_