Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1305863012: Fix windows compile error (Closed)

Created:
5 years, 3 months ago by mdjones
Modified:
5 years, 3 months ago
Reviewers:
nyquist
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@js-mojo-combine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix windows compile error Use different method of casting JavaScript value to object in an attempt to fix a compile error for windows debug builds. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/dom_distiller/content/renderer/distiller_native_javascript.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1231083007 Patch 260001

Messages

Total messages: 11 (5 generated)
mdjones
5 years, 3 months ago (2015-09-10 00:23:30 UTC) #2
nyquist
lgtm
5 years, 3 months ago (2015-09-10 00:23:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305863012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305863012/1
5 years, 3 months ago (2015-09-10 00:25:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/105057)
5 years, 3 months ago (2015-09-10 01:46:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305863012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305863012/1
5 years, 3 months ago (2015-09-10 01:49:16 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-10 02:37:02 UTC) #11 
Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698