Fix printing distilled pages

Fix printing distilled pages

The extra blank page at the beginning is removed. The max-width is
also relaxed.

The feedback form was already removed from printing in
https://crrev.com/1125343004, and it is redone in a cleaner way here.

BUG=521333
Committed: https://crrev.com/a64cd6f7f04d1244337eb00b71256f4501049ae2
Cr-Commit-Position: refs/heads/master@{#346729}

[csaavedra, 2015-08-19 12:43:51]

csaavedra@igalia.com changed reviewers:
+ csaavedra@igalia.com

[csaavedra, 2015-08-19 12:43:52]

Tested this; looking good.

https://codereview.chromium.org/1298583002/diff/1/components/dom_distiller/co...
File components/dom_distiller/core/javascript/dom_distiller_viewer.js (right):

https://codereview.chromium.org/1298583002/diff/1/components/dom_distiller/co...
components/dom_distiller/core/javascript/dom_distiller_viewer.js:132:
document.getElementById('feedbackContainer').classList.remove("hidden");
This won't apply, you need to rebase it.

[csaavedra, 2015-08-25 14:32:13]

Further comments after checking more in detail. What's stopping this from being
applied?

https://codereview.chromium.org/1298583002/diff/1/components/dom_distiller/co...
File components/dom_distiller/core/css/distilledpage.css (left):

https://codereview.chromium.org/1298583002/diff/1/components/dom_distiller/co...
components/dom_distiller/core/css/distilledpage.css:371: z-index: 2;
Is it somehow useful to leave this empty?

https://codereview.chromium.org/1298583002/diff/1/components/dom_distiller/co...
File components/dom_distiller/core/css/distilledpage.css (right):

https://codereview.chromium.org/1298583002/diff/1/components/dom_distiller/co...
components/dom_distiller/core/css/distilledpage.css:15: }
There is already a @media print somewhere below in this file. Remove the
duplicate.

[wychen, 2015-08-25 23:51:26]

wychen@chromium.org changed reviewers:
+ mdjones@chromium.org

[wychen, 2015-08-25 23:51:27]

PTAL

https://codereview.chromium.org/1298583002/diff/1/components/dom_distiller/co...
File components/dom_distiller/core/css/distilledpage.css (left):

https://codereview.chromium.org/1298583002/diff/1/components/dom_distiller/co...
components/dom_distiller/core/css/distilledpage.css:371: z-index: 2;
On 2015/08/25 14:32:13, csaavedra wrote:
> Is it somehow useful to leave this empty?

Done.

https://codereview.chromium.org/1298583002/diff/1/components/dom_distiller/co...
File components/dom_distiller/core/css/distilledpage.css (right):

https://codereview.chromium.org/1298583002/diff/1/components/dom_distiller/co...
components/dom_distiller/core/css/distilledpage.css:15: }
On 2015/08/25 14:32:13, csaavedra wrote:
> There is already a @media print somewhere below in this file. Remove the
> duplicate.

Done.

https://codereview.chromium.org/1298583002/diff/1/components/dom_distiller/co...
File components/dom_distiller/core/javascript/dom_distiller_viewer.js (right):

https://codereview.chromium.org/1298583002/diff/1/components/dom_distiller/co...
components/dom_distiller/core/javascript/dom_distiller_viewer.js:132:
document.getElementById('feedbackContainer').classList.remove("hidden");
On 2015/08/19 12:43:52, csaavedra wrote:
> This won't apply, you need to rebase it.

Done.

[wychen, 2015-08-26 16:24:40]

wychen@chromium.org changed reviewers:
+ nyquist@chromium.org

[wychen, 2015-08-26 16:24:41]

+nyquist for owner review

[nyquist, 2015-08-26 17:38:19]

lgtm

[mdjones, 2015-08-26 21:15:40]

The feedback form does not show on desktop (I realize this is not our current
target).

[csaavedra, 2015-08-27 09:18:21]

On 2015/08/26 21:15:40, mdjones wrote:
> The feedback form does not show on desktop (I realize this is not our current
> target).

Assuming the feedback form is for mobile, I'd like to remind that it's possible
to print from mobile too. In those cases the feedback form should be hidden too.

[mdjones, 2015-08-27 17:13:34]

On 2015/08/27 09:18:21, csaavedra wrote:
> On 2015/08/26 21:15:40, mdjones wrote:
> > The feedback form does not show on desktop (I realize this is not our
current
> > target).
> 
> Assuming the feedback form is for mobile, I'd like to remind that it's
possible
> to print from mobile too. In those cases the feedback form should be hidden
too.

'screen' and 'print' media queries handle this.

[wychen, 2015-08-27 20:51:00]

@mdjones: slide-down is fixed. PTAL

[wychen, 2015-09-01 18:57:56]

The CQ bit was checked by wychen@chromium.org

[wychen, 2015-09-01 18:57:56]

The patchset sent to the CQ was uploaded after l-g-t-m from nyquist@chromium.org
Link to the patchset: https://codereview.chromium.org/1298583002/#ps60001
(title: "no max-width for print, fix slide-down, fix feedback in preview")

[commit-bot: I haz the power, 2015-09-01 18:58:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1298583002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1298583002/60001

[commit-bot: I haz the power, 2015-09-01 20:23:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-01 20:23:47]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[wychen, 2015-09-01 20:44:27]

The CQ bit was checked by wychen@chromium.org

[commit-bot: I haz the power, 2015-09-01 20:44:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1298583002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1298583002/60001

[commit-bot: I haz the power, 2015-09-01 20:49:49]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-01 20:50:27]

Patchset 4 (id:??) landed as
https://crrev.com/a64cd6f7f04d1244337eb00b71256f4501049ae2
Cr-Commit-Position: refs/heads/master@{#346729}