components/dom_distiller/content/common/distiller_javascript_service.mojom - Issue 1231083007: Expose distiller functions to JavaScript

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/dom_distiller/content/common/distiller_javascript_service.mojom

Issue 1231083007: Expose distiller functions to JavaScript (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor-content

Patch Set: Address comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/dom_distiller/content/browser/distiller_javascript_service_impl.h ('K') | « components/dom_distiller/content/browser/dom_distiller_viewer_source.cc ('k') | components/dom_distiller/content/common/distiller_page_notifier_service.mojom » ('j') | components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module content;	5 module dom_distiller;

6	6

7 enum ServiceWorkerEventStatus {	7 interface DistillerJavaScriptService {
	nyquist 2015/08/19 10:59:54 It would be helpful with a short description sayin It would be helpful with a short description saying which end of the service this is in. Is this running in the context of the renderer? Or in the browser process? The direction of these mojo-service seems to confuse me every time I look at these services, and I guess a quick comment here would help me get my bearings right (same for the other .mojom file). mdjones 2015/08/19 20:25:19 Done. Show quoted text On 2015/08/19 10:59:54, nyquist (OOO - back 8-24) wrote: > It would be helpful with a short description saying which end of the service > this is in. Is this running in the context of the renderer? Or in the browser > process? > > The direction of these mojo-service seems to confuse me every time I look at > these services, and I guess a quick comment here would help me get my bearings > right (same for the other .mojom file). Done.
8 COMPLETED,	8 HandleDistillerEchoCall(string message);

9 REJECTED,

10 ABORTED,

11 MAX=ABORTED

12 };	9 };

OLD	NEW