Issue 1226373006: clang/win: Take another stab at building with -Wunused-private-field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1226373006: clang/win: Take another stab at building with -Wunused-private-field. (Closed)

Created:
5 years, 5 months ago by Nico

Modified:
5 years, 5 months ago

Reviewers:
benwells

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -4 lines)			Patch
M	build/common.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	build/config/compiler/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	third_party/cld_2/BUILD.gn	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	third_party/cld_2/cld_2.gyp	View	2 chunks	+9 lines, -1 line	0 comments	Download
M	third_party/libphonenumber/BUILD.gn	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	third_party/libphonenumber/libphonenumber.gyp	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Nico

5 years, 5 months ago (2015-07-10 22:01:21 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
28bc85d60a219a75f0b283982965c92221678018 (presubmit successful).