third_party/cld_2/BUILD.gn - Issue 1226373006: clang/win: Take another stab at building with -Wunused-private-field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/cld_2/BUILD.gn

Issue 1226373006: clang/win: Take another stab at building with -Wunused-private-field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/cld_2/BUILD.gn

diff --git a/third_party/cld_2/BUILD.gn b/third_party/cld_2/BUILD.gn

index 9789c763db48ba8a6745290d31d2ce16edf38843..303dcbf53a8d2427da61e03450e1265f23ad1040 100644

--- a/third_party/cld_2/BUILD.gn

+++ b/third_party/cld_2/BUILD.gn

@@ -83,7 +83,8 @@ source_set("cld2_platform_impl") {

config("cld2_warnings") {

if (is_clang) {

cflags = [

- # cld_2 has unused private fields.

+ # cld_2 contains unused private fields.

+ # https://code.google.com/p/cld2/issues/detail?id=37

"-Wno-unused-private-field",

]

}

« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | third_party/cld_2/cld_2.gyp » ('j') | no next file with comments »