Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Unified Diff: third_party/cld_2/cld_2.gyp

Issue 1226373006: clang/win: Take another stab at building with -Wunused-private-field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/cld_2/BUILD.gn ('k') | third_party/libphonenumber/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/cld_2/cld_2.gyp
diff --git a/third_party/cld_2/cld_2.gyp b/third_party/cld_2/cld_2.gyp
index 25feba6174858cd0d885fcdd2e2015d2ada99289..aeaea2b9435236591931f2cc1304146d9907d3a6 100644
--- a/third_party/cld_2/cld_2.gyp
+++ b/third_party/cld_2/cld_2.gyp
@@ -178,7 +178,8 @@
'clang_warning_flags': [
# The generated files don't have braces around subobject initializers.
'-Wno-missing-braces',
- # cld_2 contains unused private fields.
+ # cld_2 contains unused private fields,
+ # https://code.google.com/p/cld2/issues/detail?id=37
'-Wno-unused-private-field',
],
},
@@ -203,6 +204,13 @@
'<@(cld2_dynamic_data_loader_sources)',
],
'defines': ['CLD2_DYNAMIC_MODE'],
+ 'variables': {
+ 'clang_warning_flags': [
+ # cld_2 contains unused private fields,
+ # https://code.google.com/p/cld2/issues/detail?id=37
+ '-Wno-unused-private-field',
+ ],
+ },
},
],
}
« no previous file with comments | « third_party/cld_2/BUILD.gn ('k') | third_party/libphonenumber/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698