Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: third_party/cld_2/cld_2.gyp

Issue 1226373006: clang/win: Take another stab at building with -Wunused-private-field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/cld_2/BUILD.gn ('k') | third_party/libphonenumber/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # MAINTAINERS: 5 # MAINTAINERS:
6 # See the BUILD.gn file for more extensive comments and documentation. This 6 # See the BUILD.gn file for more extensive comments and documentation. This
7 # .gyp file exists only for compatibility with gyp. The variables defined below 7 # .gyp file exists only for compatibility with gyp. The variables defined below
8 # are used in equivalent targets in BUILD.GN. 8 # are used in equivalent targets in BUILD.GN.
9 9
10 { 10 {
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 'sources+': ['<@(cld2_data_smallest_sources)'] 171 'sources+': ['<@(cld2_data_smallest_sources)']
172 }], 172 }],
173 ['cld2_table_size==2', { 173 ['cld2_table_size==2', {
174 'sources+': ['<@(cld2_data_largest_sources)'] 174 'sources+': ['<@(cld2_data_largest_sources)']
175 }], 175 }],
176 ], 176 ],
177 'variables': { 177 'variables': {
178 'clang_warning_flags': [ 178 'clang_warning_flags': [
179 # The generated files don't have braces around subobject initializers. 179 # The generated files don't have braces around subobject initializers.
180 '-Wno-missing-braces', 180 '-Wno-missing-braces',
181 # cld_2 contains unused private fields. 181 # cld_2 contains unused private fields,
182 # https://code.google.com/p/cld2/issues/detail?id=37
182 '-Wno-unused-private-field', 183 '-Wno-unused-private-field',
183 ], 184 ],
184 }, 185 },
185 }, 186 },
186 187
187 { 188 {
188 # GN version: //third_party/cld_2:cld2_dynamic 189 # GN version: //third_party/cld_2:cld2_dynamic
189 'target_name': 'cld2_dynamic', 190 'target_name': 'cld2_dynamic',
190 'type': 'static_library', 191 'type': 'static_library',
191 'conditions': [ 192 'conditions': [
192 ['OS=="win"', { 193 ['OS=="win"', {
193 'msvs_disabled_warnings': [4267], # size_t -> int conversion. 194 'msvs_disabled_warnings': [4267], # size_t -> int conversion.
194 }], 195 }],
195 ], 196 ],
196 'include_dirs': [ 197 'include_dirs': [
197 'src/internal', 198 'src/internal',
198 'src/public', 199 'src/public',
199 ], 200 ],
200 'sources': [ 201 'sources': [
201 '<@(cld2_core_sources)', 202 '<@(cld2_core_sources)',
202 '<@(cld2_core_impl_sources)', 203 '<@(cld2_core_impl_sources)',
203 '<@(cld2_dynamic_data_loader_sources)', 204 '<@(cld2_dynamic_data_loader_sources)',
204 ], 205 ],
205 'defines': ['CLD2_DYNAMIC_MODE'], 206 'defines': ['CLD2_DYNAMIC_MODE'],
207 'variables': {
208 'clang_warning_flags': [
209 # cld_2 contains unused private fields,
210 # https://code.google.com/p/cld2/issues/detail?id=37
211 '-Wno-unused-private-field',
212 ],
213 },
206 }, 214 },
207 ], 215 ],
208 } 216 }
OLDNEW
« no previous file with comments | « third_party/cld_2/BUILD.gn ('k') | third_party/libphonenumber/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698