Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Side by Side Diff: third_party/libphonenumber/BUILD.gn

Issue 1226373006: clang/win: Take another stab at building with -Wunused-private-field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/cld_2/cld_2.gyp ('k') | third_party/libphonenumber/libphonenumber.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//testing/test.gni") 5 import("//testing/test.gni")
6 import("//third_party/protobuf/proto_library.gni") 6 import("//third_party/protobuf/proto_library.gni")
7 7
8 proto_library("proto") { 8 proto_library("proto") {
9 sources = [ 9 sources = [
10 "src/resources/phonemetadata.proto", 10 "src/resources/phonemetadata.proto",
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 "src/phonenumbers/utf/unicodetext.cc", 44 "src/phonenumbers/utf/unicodetext.cc",
45 "src/phonenumbers/utf/unilib.cc", 45 "src/phonenumbers/utf/unilib.cc",
46 ] 46 ]
47 47
48 # libphonenumber's base/logging.h is a minimal implementation where DCHECKs 48 # libphonenumber's base/logging.h is a minimal implementation where DCHECKs
49 # do not consume their arguments. This leads to unused variable warnings in 49 # do not consume their arguments. This leads to unused variable warnings in
50 # release builds. 50 # release builds.
51 configs -= [ "//build/config/compiler:chromium_code" ] 51 configs -= [ "//build/config/compiler:chromium_code" ]
52 configs += [ "//build/config/compiler:no_chromium_code" ] 52 configs += [ "//build/config/compiler:no_chromium_code" ]
53 53
54 config("libphonenumber_without_metadata_warnings") {
55 if (is_clang) {
56 cflags = [
57 # https://github.com/googlei18n/libphonenumber/pull/741
58 "-Wno-unused-private-field",
59 ]
60 }
61 }
62 configs += [ ":libphonenumber_without_metadata_warnings" ]
63
54 public_configs = [ ":libphonenumber_config" ] 64 public_configs = [ ":libphonenumber_config" ]
55 65
56 public_deps = [ 66 public_deps = [
57 ":proto", 67 ":proto",
58 ] 68 ]
59 deps = [ 69 deps = [
60 ":proto", 70 ":proto",
61 "//third_party/icu", 71 "//third_party/icu",
62 "//third_party/protobuf:protobuf_lite", 72 "//third_party/protobuf:protobuf_lite",
63 ] 73 ]
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 deps = [ 107 deps = [
98 ":libphonenumber_without_metadata", 108 ":libphonenumber_without_metadata",
99 "//base", 109 "//base",
100 "//base/test:run_all_unittests", 110 "//base/test:run_all_unittests",
101 "//base/third_party/dynamic_annotations", 111 "//base/third_party/dynamic_annotations",
102 "//third_party/icu", 112 "//third_party/icu",
103 "//testing/gmock", 113 "//testing/gmock",
104 "//testing/gtest", 114 "//testing/gtest",
105 ] 115 ]
106 } 116 }
OLDNEW
« no previous file with comments | « third_party/cld_2/cld_2.gyp ('k') | third_party/libphonenumber/libphonenumber.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698