Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1226113007: Add @override annotation to known overriden methods (Closed)

Created:
5 years, 5 months ago by Chinmay
Modified:
5 years, 5 months ago
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add @override annotation to known overriden methods * Does not add the annotation to interface method implementations

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+552 lines, -43 lines) Patch
M sky/sdk/example/demo_launcher/lib/main.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/example/fitness/lib/home.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/sdk/example/fitness/lib/main.dart View 3 chunks +3 lines, -1 line 0 comments Download
M sky/sdk/example/fitness/lib/settings.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/example/game/lib/action.dart View 8 chunks +10 lines, -0 lines 0 comments Download
M sky/sdk/example/game/lib/game_demo_world.dart View 5 chunks +5 lines, -2 lines 0 comments Download
M sky/sdk/example/game/lib/node_with_size.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/example/game/lib/particle_system.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/sdk/example/game/lib/sprite.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M sky/sdk/example/rendering/sector_layout.dart View 18 chunks +31 lines, -1 line 0 comments Download
M sky/sdk/example/rendering/simple_autolayout.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M sky/sdk/example/rendering/solid_color_box.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M sky/sdk/example/rendering/touch_demo.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M sky/sdk/example/widgets/block_viewport.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/example/widgets/card_collection.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/example/widgets/container.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/example/widgets/navigation.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/example/widgets/piano.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/example/widgets/sector.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/example/widgets/spinning_mixed.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/example/widgets/styled_text.dart View 2 chunks +2 lines, -1 line 0 comments Download
M sky/sdk/example/widgets/tabs.dart View 2 chunks +2 lines, -1 line 0 comments Download
M sky/sdk/lib/animation/animation_performance.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/lib/animation/generators.dart View 6 chunks +6 lines, -0 lines 0 comments Download
M sky/sdk/lib/animation/mechanics.dart View 8 chunks +8 lines, -0 lines 0 comments Download
M sky/sdk/lib/animation/scroll_behavior.dart View 3 chunks +3 lines, -0 lines 0 comments Download
M sky/sdk/lib/editing/editable_text.dart View 4 chunks +4 lines, -1 line 0 comments Download
M sky/sdk/lib/mojo/asset_bundle.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/painting/box_painter.dart View 8 chunks +13 lines, -0 lines 0 comments Download
M sky/sdk/lib/painting/text_style.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M sky/sdk/lib/rendering/auto_layout.dart View 5 chunks +19 lines, -13 lines 0 comments Download
M sky/sdk/lib/rendering/block.dart View 11 chunks +19 lines, -0 lines 0 comments Download
M sky/sdk/lib/rendering/box.dart View 54 chunks +88 lines, -0 lines 0 comments Download
M sky/sdk/lib/rendering/flex.dart View 11 chunks +14 lines, -3 lines 0 comments Download
M sky/sdk/lib/rendering/object.dart View 4 chunks +5 lines, -0 lines 0 comments Download
M sky/sdk/lib/rendering/paragraph.dart View 11 chunks +18 lines, -1 line 0 comments Download
M sky/sdk/lib/rendering/sky_binding.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/lib/rendering/stack.dart View 8 chunks +11 lines, -1 line 0 comments Download
M sky/sdk/lib/widgets/animated_component.dart View 3 chunks +3 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/basic.dart View 32 chunks +79 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/block_viewport.dart View 8 chunks +15 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/button_base.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/card.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/lib/widgets/checkbox.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/default_text_style.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/lib/widgets/dialog.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/lib/widgets/drawer.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/drawer_header.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/lib/widgets/fixed_height_scrollable.dart View 3 chunks +6 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/flat_button.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/floating_action_button.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/icon.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/lib/widgets/icon_button.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/lib/widgets/ink_well.dart View 3 chunks +6 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/material.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/lib/widgets/material_button.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/menu_divider.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/lib/widgets/menu_item.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/modal_overlay.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/lib/widgets/navigator.dart View 4 chunks +6 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/popup_menu.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/popup_menu_item.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/lib/widgets/radio.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/raised_button.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/scaffold.dart View 10 chunks +17 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/scrollable.dart View 3 chunks +3 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/scrollable_list.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/snack_bar.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/tabs.dart View 17 chunks +27 lines, -6 lines 0 comments Download
M sky/sdk/lib/widgets/task_description.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/lib/widgets/theme.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/lib/widgets/toggleable.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/tool_bar.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/lib/widgets/widget.dart View 27 chunks +47 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Chinmay
5 years, 5 months ago (2015-07-09 21:37:10 UTC) #2
Hixie
How does one make sure that one doesn't break this?
5 years, 5 months ago (2015-07-09 21:48:46 UTC) #3
Chinmay
On 2015/07/09 at 21:48:46, ianh wrote: > How does one make sure that one doesn't ...
5 years, 5 months ago (2015-07-09 21:52:16 UTC) #4
Chinmay
5 years, 5 months ago (2015-07-09 22:30:39 UTC) #5
On 2015/07/09 at 21:52:16, Chinmay wrote:
> On 2015/07/09 at 21:48:46, ianh wrote:
> > How does one make sure that one doesn't break this?
> 
> I am working on making Dart analyzer tell you when you do. This just adds the
annotation to all known overrides. For new code, if you are overriding a method,
just add the annotation. If you miss it, its no big deal since it is very
obvious that the annotation when in an IDE, we can add the missing one as we
find them.

Closing. Discussion in IRC

Powered by Google App Engine
This is Rietveld 408576698