Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: sky/sdk/lib/editing/editable_text.dart

Issue 1226113007: Add @override annotation to known overriden methods (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/animation/scroll_behavior.dart ('k') | sky/sdk/lib/mojo/asset_bundle.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/editing/editable_text.dart
diff --git a/sky/sdk/lib/editing/editable_text.dart b/sky/sdk/lib/editing/editable_text.dart
index 6bf9c8d44605027d30250c9ab0fa188548b635bf..d93e89ec2c4f340b5472eff3e4ec4e018c40b5b2 100644
--- a/sky/sdk/lib/editing/editable_text.dart
+++ b/sky/sdk/lib/editing/editable_text.dart
@@ -29,6 +29,7 @@ class EditableText extends StatefulComponent {
TextStyle style;
Color cursorColor;
+ @override
void syncFields(EditableText source) {
value = source.value;
focused = source.focused;
@@ -51,6 +52,7 @@ class EditableText extends StatefulComponent {
new Duration(milliseconds: _kCursorBlinkPeriod), _cursorTick);
}
+ @override
void didUnmount() {
if (_cursorTimer != null)
_stopCursorTimer();
@@ -68,7 +70,7 @@ class EditableText extends StatefulComponent {
return;
Rect cursorRect = new Rect.fromLTWH(
- _kCursorGap,
+ _kCursorGap,
-_kCursorHeightOffset,
_kCursorWidth,
style.fontSize + 2 * _kCursorHeightOffset
@@ -76,6 +78,7 @@ class EditableText extends StatefulComponent {
canvas.drawRect(cursorRect, new Paint()..color = cursorColor);
}
+ @override
Widget build() {
assert(style != null);
assert(focused != null);
« no previous file with comments | « sky/sdk/lib/animation/scroll_behavior.dart ('k') | sky/sdk/lib/mojo/asset_bundle.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698