Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: sky/sdk/lib/animation/scroll_behavior.dart

Issue 1226113007: Add @override annotation to known overriden methods (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/animation/mechanics.dart ('k') | sky/sdk/lib/editing/editable_text.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/animation/scroll_behavior.dart
diff --git a/sky/sdk/lib/animation/scroll_behavior.dart b/sky/sdk/lib/animation/scroll_behavior.dart
index f94e5378a085e84ac4feef577df49b9df16fdf25..5afcd67006da0a3ad6a713e0f81d507631509e92 100644
--- a/sky/sdk/lib/animation/scroll_behavior.dart
+++ b/sky/sdk/lib/animation/scroll_behavior.dart
@@ -24,6 +24,7 @@ class BoundedScrollBehavior extends ScrollBehavior {
BoundedScrollBehavior({this.minOffset: 0.0, this.maxOffset});
+ @override
double applyCurve(double scrollOffset, double scrollDelta) {
double newScrollOffset = scrollOffset + scrollDelta;
if (minOffset != null)
@@ -60,6 +61,7 @@ class OverscrollBehavior extends ScrollBehavior {
double get maxScroll => math.max(0.0, _contentsHeight - _containerHeight);
+ @override
Simulation release(Particle particle) {
System system;
if ((particle.position >= 0.0) && (particle.position < maxScroll)) {
@@ -97,6 +99,7 @@ class OverscrollBehavior extends ScrollBehavior {
targetPosition: maxScroll);
}
+ @override
double applyCurve(double scrollOffset, double scrollDelta) {
double newScrollOffset = scrollOffset + scrollDelta;
// If we're overscrolling, we want move the scroll offset 2x
« no previous file with comments | « sky/sdk/lib/animation/mechanics.dart ('k') | sky/sdk/lib/editing/editable_text.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698