Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1225673007: Initial CL to create dummy GrShaderDataManager and thread it through (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Initial CL to create dummy GrShaderDataManager and thread it through TBR=bsalomon@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/8ca93e7c733ab064c8a9e03715ac405ae739cf51

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 1

Patch Set 3 : rebase #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -52 lines) Patch
M gm/dcshader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gyp/gpu.gypi View 1 2 chunks +2 lines, -0 lines 0 comments Download
M include/core/SkShader.h View 2 chunks +2 lines, -1 line 0 comments Download
M include/effects/SkPerlinNoiseShader.h View 1 chunk +1 line, -1 line 1 comment Download
M include/gpu/GrPaint.h View 3 chunks +4 lines, -0 lines 1 comment Download
A + include/gpu/GrShaderDataManager.h View 1 1 chunk +5 lines, -5 lines 1 comment Download
M src/core/SkBitmapProcShader.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapProcShader.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkColorShader.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkLocalMatrixShader.h View 1 chunk +5 lines, -3 lines 0 comments Download
M src/core/SkPictureShader.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPictureShader.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M src/core/SkShader.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 3 chunks +6 lines, -3 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 3 chunks +5 lines, -3 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 3 chunks +4 lines, -2 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 6 chunks +16 lines, -11 lines 0 comments Download
A + src/gpu/GrShaderDataManager.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 21 (7 generated)
joshualitt
ptal
5 years, 5 months ago (2015-07-07 17:18:05 UTC) #2
robertphillips
looks reasonable to me - Brian? https://codereview.chromium.org/1225673007/diff/20001/include/gpu/GrShaderDataManager.h File include/gpu/GrShaderDataManager.h (right): https://codereview.chromium.org/1225673007/diff/20001/include/gpu/GrShaderDataManager.h#newcode10 include/gpu/GrShaderDataManager.h:10: Is the API ...
5 years, 5 months ago (2015-07-07 17:27:35 UTC) #3
robertphillips
lgtm
5 years, 5 months ago (2015-07-08 13:27:09 UTC) #4
joshualitt
5 years, 5 months ago (2015-07-08 13:29:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225673007/20001
5 years, 5 months ago (2015-07-08 13:30:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/1820) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
5 years, 5 months ago (2015-07-08 13:30:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225673007/40001
5 years, 5 months ago (2015-07-08 13:44:12 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/913)
5 years, 5 months ago (2015-07-08 13:45:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225673007/40001
5 years, 5 months ago (2015-07-08 13:48:22 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/8ca93e7c733ab064c8a9e03715ac405ae739cf51
5 years, 5 months ago (2015-07-08 13:51:49 UTC) #17
bsalomon
https://codereview.chromium.org/1225673007/diff/40001/include/effects/SkPerlinNoiseShader.h File include/effects/SkPerlinNoiseShader.h (right): https://codereview.chromium.org/1225673007/diff/40001/include/effects/SkPerlinNoiseShader.h#newcode99 include/effects/SkPerlinNoiseShader.h:99: virtual bool asFragmentProcessor(GrContext* context, const SkPaint&, const SkMatrix& viewM, ...
5 years, 5 months ago (2015-07-08 14:56:03 UTC) #18
joshualitt
On 2015/07/08 14:56:03, bsalomon wrote: > https://codereview.chromium.org/1225673007/diff/40001/include/effects/SkPerlinNoiseShader.h > File include/effects/SkPerlinNoiseShader.h (right): > > https://codereview.chromium.org/1225673007/diff/40001/include/effects/SkPerlinNoiseShader.h#newcode99 > ...
5 years, 5 months ago (2015-07-08 14:58:51 UTC) #19
joshualitt
On 2015/07/08 14:56:03, bsalomon wrote: > https://codereview.chromium.org/1225673007/diff/40001/include/effects/SkPerlinNoiseShader.h > File include/effects/SkPerlinNoiseShader.h (right): > > https://codereview.chromium.org/1225673007/diff/40001/include/effects/SkPerlinNoiseShader.h#newcode99 > ...
5 years, 5 months ago (2015-07-08 14:58:52 UTC) #20
bsalomon
5 years, 5 months ago (2015-07-08 15:13:54 UTC) #21
Message was sent while issue was closed. 
On 2015/07/08 14:58:52, joshualitt wrote:
> On 2015/07/08 14:56:03, bsalomon wrote:
> >
>
https://codereview.chromium.org/1225673007/diff/40001/include/effects/SkPerli...
> > File include/effects/SkPerlinNoiseShader.h (right):
> > 
> >
>
https://codereview.chromium.org/1225673007/diff/40001/include/effects/SkPerli...
> > include/effects/SkPerlinNoiseShader.h:99: virtual bool
> > asFragmentProcessor(GrContext* context, const SkPaint&, const SkMatrix&
viewM,
> > Poor camel, time for an args struct!
> I have a bunch of CLs on top of this, but we can talk about doing this
> afterwards.
> > 
> > I tried to text as much yesterday when you chatted me but my phone kept
> > transcribing "argument truck"
> > 
> > https://codereview.chromium.org/1225673007/diff/40001/include/gpu/GrPaint.h
> > File include/gpu/GrPaint.h (right):
> > 
> >
>
https://codereview.chromium.org/1225673007/diff/40001/include/gpu/GrPaint.h#n...
> > include/gpu/GrPaint.h:140: GrShaderDataManager* getShaderDataManager() {
> return
> > &fShaderDataManager; }
> > Is this supposed to R/W?
> Yea, the processors need to use it.

But they don't see the GrPaint... just curious why we need a non-const accessor
here.

> > 
> >
>
https://codereview.chromium.org/1225673007/diff/40001/include/gpu/GrShaderDat...
> > File include/gpu/GrShaderDataManager.h (right):
> > 
> >
>
https://codereview.chromium.org/1225673007/diff/40001/include/gpu/GrShaderDat...
> > include/gpu/GrShaderDataManager.h:11: class GrShaderDataManager {};
> > I wonder if it should be ProcessorDataManager?
> Sure, when I'm done threading we can rename.

Powered by Google App Engine
This is Rietveld 408576698