Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1223393002: Add some missing virtual destructors to base classes. (Closed)

Created:
5 years, 5 months ago by Daniel Erat
Modified:
5 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add some missing virtual destructors to base classes. I started by adding virtual destructors to the following classes: base::FileTracing::Provider base::internal::PostTaskAndReplyImpl base::PostTaskAndReplyWorkerPool base::TraceLog::EnabledStateObserver But then that triggered a bunch of other errors in downstream classes that are missing 'override', so I'm updating those too. BUG=none Committed: https://crrev.com/99c5d9fb18a5f8dd987605e25859631fa0492dc1 Cr-Commit-Position: refs/heads/master@{#338509}

Patch Set 1 #

Patch Set 2 : add missing override #

Patch Set 3 : more overrides #

Patch Set 4 : and another one #

Patch Set 5 : sigh #

Patch Set 6 : another one, now in content #

Patch Set 7 : update V8SamplingProfiler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M base/files/file_tracing.h View 1 chunk +2 lines, -0 lines 0 comments Download
M base/threading/post_task_and_reply_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M base/threading/worker_pool.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/trace_event/memory_dump_manager.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/trace_event_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M base/trace_event/trace_event_memory.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/trace_event_system_stats_monitor.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/trace_event_unittest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/tracing/file_tracing_provider_impl.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/devtools/v8_sampling_profiler.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 38 (17 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223393002/1
5 years, 5 months ago (2015-07-09 19:11:45 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/89990)
5 years, 5 months ago (2015-07-09 19:25:04 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223393002/20001
5 years, 5 months ago (2015-07-09 19:40:28 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/90014) android_chromium_gn_compile_rel on ...
5 years, 5 months ago (2015-07-09 19:52:54 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223393002/40001
5 years, 5 months ago (2015-07-09 20:07:10 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/72152) (exceeded global ...
5 years, 5 months ago (2015-07-09 20:18:28 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223393002/60001
5 years, 5 months ago (2015-07-09 20:35:29 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/29088) (exceeded global ...
5 years, 5 months ago (2015-07-09 20:52:20 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223393002/80001
5 years, 5 months ago (2015-07-09 21:12:51 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/72185)
5 years, 5 months ago (2015-07-09 21:37:43 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223393002/100001
5 years, 5 months ago (2015-07-09 21:38:04 UTC) #21
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/72212) mac_chromium_rel_ng on ...
5 years, 5 months ago (2015-07-09 22:09:47 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223393002/120001
5 years, 5 months ago (2015-07-09 22:32:02 UTC) #25
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-10 00:10:38 UTC) #27
Daniel Erat
5 years, 5 months ago (2015-07-10 13:18:17 UTC) #29
jam
lgtm
5 years, 5 months ago (2015-07-10 17:21:20 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223393002/120001
5 years, 5 months ago (2015-07-12 12:02:48 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/26978) (exceeded global retry quota)
5 years, 5 months ago (2015-07-12 12:52:54 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223393002/120001
5 years, 5 months ago (2015-07-13 13:43:43 UTC) #36
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 5 months ago (2015-07-13 15:22:34 UTC) #37
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 15:23:33 UTC) #38
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/99c5d9fb18a5f8dd987605e25859631fa0492dc1
Cr-Commit-Position: refs/heads/master@{#338509}

Powered by Google App Engine
This is Rietveld 408576698