Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: base/trace_event/trace_event_unittest.cc

Issue 1223393002: Add some missing virtual destructors to base classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update V8SamplingProfiler Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <math.h> 5 #include <math.h>
6 #include <cstdlib> 6 #include <cstdlib>
7 7
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/json/json_reader.h" 10 #include "base/json/json_reader.h"
(...skipping 1002 matching lines...) Expand 10 before | Expand all | Expand 10 after
1013 1013
1014 // Cleanup. 1014 // Cleanup.
1015 TraceLog::GetInstance()->RemoveEnabledStateObserver(&observer); 1015 TraceLog::GetInstance()->RemoveEnabledStateObserver(&observer);
1016 } 1016 }
1017 1017
1018 // Tests the IsEnabled() state of TraceLog changes before callbacks. 1018 // Tests the IsEnabled() state of TraceLog changes before callbacks.
1019 class AfterStateChangeEnabledStateObserver 1019 class AfterStateChangeEnabledStateObserver
1020 : public TraceLog::EnabledStateObserver { 1020 : public TraceLog::EnabledStateObserver {
1021 public: 1021 public:
1022 AfterStateChangeEnabledStateObserver() {} 1022 AfterStateChangeEnabledStateObserver() {}
1023 virtual ~AfterStateChangeEnabledStateObserver() {} 1023 ~AfterStateChangeEnabledStateObserver() override {}
1024 1024
1025 // TraceLog::EnabledStateObserver overrides: 1025 // TraceLog::EnabledStateObserver overrides:
1026 void OnTraceLogEnabled() override { 1026 void OnTraceLogEnabled() override {
1027 EXPECT_TRUE(TraceLog::GetInstance()->IsEnabled()); 1027 EXPECT_TRUE(TraceLog::GetInstance()->IsEnabled());
1028 } 1028 }
1029 1029
1030 void OnTraceLogDisabled() override { 1030 void OnTraceLogDisabled() override {
1031 EXPECT_FALSE(TraceLog::GetInstance()->IsEnabled()); 1031 EXPECT_FALSE(TraceLog::GetInstance()->IsEnabled());
1032 } 1032 }
1033 }; 1033 };
(...skipping 10 matching lines...) Expand all
1044 EXPECT_FALSE(TraceLog::GetInstance()->IsEnabled()); 1044 EXPECT_FALSE(TraceLog::GetInstance()->IsEnabled());
1045 1045
1046 TraceLog::GetInstance()->RemoveEnabledStateObserver(&observer); 1046 TraceLog::GetInstance()->RemoveEnabledStateObserver(&observer);
1047 } 1047 }
1048 1048
1049 // Tests that a state observer can remove itself during a callback. 1049 // Tests that a state observer can remove itself during a callback.
1050 class SelfRemovingEnabledStateObserver 1050 class SelfRemovingEnabledStateObserver
1051 : public TraceLog::EnabledStateObserver { 1051 : public TraceLog::EnabledStateObserver {
1052 public: 1052 public:
1053 SelfRemovingEnabledStateObserver() {} 1053 SelfRemovingEnabledStateObserver() {}
1054 virtual ~SelfRemovingEnabledStateObserver() {} 1054 ~SelfRemovingEnabledStateObserver() override {}
1055 1055
1056 // TraceLog::EnabledStateObserver overrides: 1056 // TraceLog::EnabledStateObserver overrides:
1057 void OnTraceLogEnabled() override {} 1057 void OnTraceLogEnabled() override {}
1058 1058
1059 void OnTraceLogDisabled() override { 1059 void OnTraceLogDisabled() override {
1060 TraceLog::GetInstance()->RemoveEnabledStateObserver(this); 1060 TraceLog::GetInstance()->RemoveEnabledStateObserver(this);
1061 } 1061 }
1062 }; 1062 };
1063 1063
1064 TEST_F(TraceEventTestFixture, SelfRemovingObserver) { 1064 TEST_F(TraceEventTestFixture, SelfRemovingObserver) {
(...skipping 1893 matching lines...) Expand 10 before | Expand all | Expand 10 after
2958 } 2958 }
2959 2959
2960 TEST_F(TraceEventTestFixture, SyntheticDelayConfigurationToString) { 2960 TEST_F(TraceEventTestFixture, SyntheticDelayConfigurationToString) {
2961 const char filter[] = "DELAY(test.Delay;16;oneshot)"; 2961 const char filter[] = "DELAY(test.Delay;16;oneshot)";
2962 TraceConfig config(filter, ""); 2962 TraceConfig config(filter, "");
2963 EXPECT_EQ(filter, config.ToCategoryFilterString()); 2963 EXPECT_EQ(filter, config.ToCategoryFilterString());
2964 } 2964 }
2965 2965
2966 } // namespace trace_event 2966 } // namespace trace_event
2967 } // namespace base 2967 } // namespace base
OLDNEW
« no previous file with comments | « base/trace_event/trace_event_system_stats_monitor.h ('k') | content/browser/tracing/file_tracing_provider_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698