content/renderer/devtools/v8_sampling_profiler.h - Issue 1223393002: Add some missing virtual destructors to base classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/devtools/v8_sampling_profiler.h

Issue 1223393002: Add some missing virtual destructors to base classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update V8SamplingProfiler Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/devtools/v8_sampling_profiler.h

diff --git a/content/renderer/devtools/v8_sampling_profiler.h b/content/renderer/devtools/v8_sampling_profiler.h

index 96a50b0745b6406fde0da6bf7b8de64abd1b6fa4..156a01ee95e808db6253759c846e405c51dce4c1 100644

--- a/content/renderer/devtools/v8_sampling_profiler.h

+++ b/content/renderer/devtools/v8_sampling_profiler.h

@@ -21,7 +21,7 @@ class CONTENT_EXPORT V8SamplingProfiler final

: public base::trace_event::TraceLog::EnabledStateObserver {

public:

explicit V8SamplingProfiler(bool underTest = false);

- ~V8SamplingProfiler();

+ ~V8SamplingProfiler() override;

// Implementation of TraceLog::EnabledStateObserver

void OnTraceLogEnabled() override;

« no previous file with comments | « content/browser/tracing/file_tracing_provider_impl.h ('k') | no next file » | no next file with comments »