Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: base/trace_event/trace_event_impl.h

Issue 1223393002: Add some missing virtual destructors to base classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update V8SamplingProfiler Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/trace_event/memory_dump_manager.h ('k') | base/trace_event/trace_event_memory.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5
6 #ifndef BASE_TRACE_EVENT_TRACE_EVENT_IMPL_H_ 6 #ifndef BASE_TRACE_EVENT_TRACE_EVENT_IMPL_H_
7 #define BASE_TRACE_EVENT_TRACE_EVENT_IMPL_H_ 7 #define BASE_TRACE_EVENT_TRACE_EVENT_IMPL_H_
8 8
9 #include <stack> 9 #include <stack>
10 #include <string> 10 #include <string>
(...skipping 349 matching lines...) Expand 10 before | Expand all | Expand 10 after
360 void StartATrace(); 360 void StartATrace();
361 void StopATrace(); 361 void StopATrace();
362 void AddClockSyncMetadataEvent(); 362 void AddClockSyncMetadataEvent();
363 #endif 363 #endif
364 364
365 // Enabled state listeners give a callback when tracing is enabled or 365 // Enabled state listeners give a callback when tracing is enabled or
366 // disabled. This can be used to tie into other library's tracing systems 366 // disabled. This can be used to tie into other library's tracing systems
367 // on-demand. 367 // on-demand.
368 class BASE_EXPORT EnabledStateObserver { 368 class BASE_EXPORT EnabledStateObserver {
369 public: 369 public:
370 virtual ~EnabledStateObserver() = default;
371
370 // Called just after the tracing system becomes enabled, outside of the 372 // Called just after the tracing system becomes enabled, outside of the
371 // |lock_|. TraceLog::IsEnabled() is true at this point. 373 // |lock_|. TraceLog::IsEnabled() is true at this point.
372 virtual void OnTraceLogEnabled() = 0; 374 virtual void OnTraceLogEnabled() = 0;
373 375
374 // Called just after the tracing system disables, outside of the |lock_|. 376 // Called just after the tracing system disables, outside of the |lock_|.
375 // TraceLog::IsEnabled() is false at this point. 377 // TraceLog::IsEnabled() is false at this point.
376 virtual void OnTraceLogDisabled() = 0; 378 virtual void OnTraceLogDisabled() = 0;
377 }; 379 };
378 void AddEnabledStateObserver(EnabledStateObserver* listener); 380 void AddEnabledStateObserver(EnabledStateObserver* listener);
379 void RemoveEnabledStateObserver(EnabledStateObserver* listener); 381 void RemoveEnabledStateObserver(EnabledStateObserver* listener);
(...skipping 326 matching lines...) Expand 10 before | Expand all | Expand 10 after
706 subtle::AtomicWord generation_; 708 subtle::AtomicWord generation_;
707 bool use_worker_thread_; 709 bool use_worker_thread_;
708 710
709 DISALLOW_COPY_AND_ASSIGN(TraceLog); 711 DISALLOW_COPY_AND_ASSIGN(TraceLog);
710 }; 712 };
711 713
712 } // namespace trace_event 714 } // namespace trace_event
713 } // namespace base 715 } // namespace base
714 716
715 #endif // BASE_TRACE_EVENT_TRACE_EVENT_IMPL_H_ 717 #endif // BASE_TRACE_EVENT_TRACE_EVENT_IMPL_H_
OLDNEW
« no previous file with comments | « base/trace_event/memory_dump_manager.h ('k') | base/trace_event/trace_event_memory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698