base/trace_event/memory_dump_manager.h - Issue 1223393002: Add some missing virtual destructors to base classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/memory_dump_manager.h

Issue 1223393002: Add some missing virtual destructors to base classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update V8SamplingProfiler Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/trace_event/memory_dump_manager.h

diff --git a/base/trace_event/memory_dump_manager.h b/base/trace_event/memory_dump_manager.h

index 497e94ee3b068d8efb91996a42822823049c7eae..746c7d577eee4ed6720d792a10e100ea7c52ab93 100644

--- a/base/trace_event/memory_dump_manager.h

+++ b/base/trace_event/memory_dump_manager.h

@@ -126,7 +126,7 @@ class BASE_EXPORT MemoryDumpManager : public TraceLog::EnabledStateObserver {

static void SetInstanceForTesting(MemoryDumpManager* instance);

MemoryDumpManager();

- virtual ~MemoryDumpManager();

+ ~MemoryDumpManager() override;

// Internal, used only by MemoryDumpManagerDelegate.

// Creates a memory dump for the current process and appends it to the trace.

« no previous file with comments | « base/threading/worker_pool.cc ('k') | base/trace_event/trace_event_impl.h » ('j') | no next file with comments »