Issue 12209008: Follow-on fixes and naming changes for https://codereview.chromium.org/12086077/

Issue 12209008: Follow-on fixes and naming changes for https://codereview.chromium.org/12086077/ (Closed)

Created:
7 years, 10 months ago by jschuh

Modified:
7 years, 10 months ago

Reviewers:
jschuh

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Follow-on fixes and naming changes for https://codereview.chromium.org/12086077/ BUG=172573 Review URL: https://codereview.chromium.org/12177018 Recommit of: https://codereview.chromium.org/12177018 TBR=cevans@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180700

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -49 lines)			Patch
M	chrome/browser/plugins/chrome_plugin_service_filter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/plugins/chrome_plugin_service_filter.cc	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/plugins/plugin_info_message_filter.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/plugins/plugin_info_message_filter.cc	View	3 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/renderer_host/plugin_info_message_filter_unittest.cc	View	2 chunks	+12 lines, -12 lines	0 comments	Download
M	content/browser/plugin_service_impl.cc	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	content/browser/plugin_service_impl_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/render_message_filter.cc	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	content/public/browser/plugin_service_filter.h	View	1 chunk	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/12209008/1

7 years, 10 months ago (2013-02-05 06:31:08 UTC) #2

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=96284

7 years, 10 months ago (2013-02-05 08:31:46 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/12209008/1

7 years, 10 months ago (2013-02-05 13:10:16 UTC) #4

commit-bot: I haz the power

7 years, 10 months ago (2013-02-05 15:02:51 UTC) #5

Failed to apply the patch.
Sending        chrome/browser/plugins/chrome_plugin_service_filter.cc
Sending        chrome/browser/plugins/chrome_plugin_service_filter.h
Sending        chrome/browser/plugins/plugin_info_message_filter.cc
Sending        chrome/browser/plugins/plugin_info_message_filter.h
Sending       
chrome/browser/renderer_host/plugin_info_message_filter_unittest.cc
Sending        content/browser/plugin_service_impl.cc
Sending        content/browser/plugin_service_impl_browsertest.cc
Sending        content/browser/renderer_host/render_message_filter.cc
Sending        content/public/browser/plugin_service_filter.h
Transmitting file data .........svn: Commit failed (details follow):
svn: Conflict at '/trunk/src/content/browser/plugin_service_impl.cc'

Expand Messages | Collapse Messages