Issue 12177018: Follow-on fixes and naming changes for https://codereview.chromium.org/12086077/

Issue 12177018: Follow-on fixes and naming changes for https://codereview.chromium.org/12086077/ (Closed)

Created:
7 years, 10 months ago by Chris Evans

Modified:
7 years, 10 months ago

Reviewers:
Bernhard Bauer, jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -49 lines)			Patch
M	chrome/browser/plugins/chrome_plugin_service_filter.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/plugins/chrome_plugin_service_filter.cc	View		2 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/plugins/plugin_info_message_filter.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/plugins/plugin_info_message_filter.cc	View		3 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/renderer_host/plugin_info_message_filter_unittest.cc	View	1	2 chunks	+12 lines, -12 lines	0 comments	Download
M	content/browser/plugin_service_impl.cc	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	content/browser/plugin_service_impl_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/render_message_filter.cc	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	content/public/browser/plugin_service_filter.h	View		1 chunk	+8 lines, -8 lines	0 comments	Download

Total messages: 9 (0 generated)

Chris Evans

On 2013/02/04 16:02:47, Bernhard Bauer wrote: > LGTM, thanks for the quick turnaround! +jam -- ...

7 years, 10 months ago (2013-02-04 16:40:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cevans@chromium.org/12177018/1

7 years, 10 months ago (2013-02-04 17:51:03 UTC) #5

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 10 months ago (2013-02-04 18:20:21 UTC) #6

Chris Evans

On 2013/02/04 18:20:21, I haz the power (commit-bot) wrote: > Sorry for I got bad ...

7 years, 10 months ago (2013-02-04 18:31:59 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cevans@chromium.org/12177018/10002

7 years, 10 months ago (2013-02-04 18:34:23 UTC) #8

commit-bot: I haz the power

7 years, 10 months ago (2013-02-04 21:39:42 UTC) #9

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...