add ability to get FBO ID to Surface

add ability to get FBO ID to Surface

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/81793410a80b1bb147e765caccdd7fb36e34edf8

[joshualitt, 2015-06-30 15:36:26]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com

[joshualitt, 2015-06-30 15:36:26]

ptal

[joshualitt, 2015-06-30 15:47:49]

joshualitt@google.com changed reviewers:
+ reed@google.com

[joshualitt, 2015-06-30 15:47:50]

feedback incorporated, adding Mike.

[bsalomon, 2015-06-30 15:49:58]

https://codereview.chromium.org/1220733007/diff/60001/src/image/SkSurface_Gpu...
File src/image/SkSurface_Gpu.cpp (right):

https://codereview.chromium.org/1220733007/diff/60001/src/image/SkSurface_Gpu...
src/image/SkSurface_Gpu.cpp:48: return rt->asTexture()->getTextureHandle();
Eek... this is an existing bug I should have caught when reviewing Mike's CL.
Must check for NULL asTexture() here.

[joshualitt, 2015-06-30 16:13:38]

On 2015/06/30 15:49:58, bsalomon wrote:
>
https://codereview.chromium.org/1220733007/diff/60001/src/image/SkSurface_Gpu...
> File src/image/SkSurface_Gpu.cpp (right):
> 
>
https://codereview.chromium.org/1220733007/diff/60001/src/image/SkSurface_Gpu...
> src/image/SkSurface_Gpu.cpp:48: return rt->asTexture()->getTextureHandle();
> Eek... this is an existing bug I should have caught when reviewing Mike's CL.
> Must check for NULL asTexture() here.

done

[joshualitt, 2015-06-30 16:20:56]

Patchset #6 (id:100001) has been deleted

[robertphillips, 2015-07-06 15:29:01]

robertphillips@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2015-07-06 15:29:02]

nits

https://codereview.chromium.org/1220733007/diff/80001/include/core/SkSurface.h
File include/core/SkSurface.h (right):

https://codereview.chromium.org/1220733007/diff/80001/include/core/SkSurface....
include/core/SkSurface.h:161: *  Retrieves the backend API handle of the
RenderTarget backing this surface.  Callers must
return -> returns ?

https://codereview.chromium.org/1220733007/diff/80001/include/core/SkSurface....
include/core/SkSurface.h:163: *
On -> In ?

[joshualitt, 2015-07-08 15:33:30]

On 2015/07/06 15:29:02, robertphillips wrote:
> nits
> 
> https://codereview.chromium.org/1220733007/diff/80001/include/core/SkSurface.h
> File include/core/SkSurface.h (right):
> 
>
https://codereview.chromium.org/1220733007/diff/80001/include/core/SkSurface....
> include/core/SkSurface.h:161: *  Retrieves the backend API handle of the
> RenderTarget backing this surface.  Callers must
> return -> returns ?
> 
>
https://codereview.chromium.org/1220733007/diff/80001/include/core/SkSurface....
> include/core/SkSurface.h:163: *
> On -> In ?

feedback incorporated

[bsalomon, 2015-07-08 17:21:46]

lgtm with some nits

https://codereview.chromium.org/1220733007/diff/140001/include/core/SkSurface.h
File include/core/SkSurface.h (right):

https://codereview.chromium.org/1220733007/diff/140001/include/core/SkSurface...
include/core/SkSurface.h:168: static const BackendHandleAccess
kFlushRead_TextureHandleAccess =
Comment about these being legacy aliases that will be removed soon?

https://codereview.chromium.org/1220733007/diff/140001/src/image/SkSurface_Gp...
File src/image/SkSurface_Gpu.cpp (right):

https://codereview.chromium.org/1220733007/diff/140001/src/image/SkSurface_Gp...
src/image/SkSurface_Gpu.cpp:49: if (rt->asTexture()) {
save var rather than double call?

[joshualitt, 2015-07-08 18:36:59]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-07-08 18:37:00]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1220733007/#ps160001
(title: "nits")

[commit-bot: I haz the power, 2015-07-08 18:37:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1220733007/160001

[commit-bot: I haz the power, 2015-07-08 18:40:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-08 18:40:29]

Try jobs failed on following builders:
  Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[joshualitt, 2015-07-08 19:46:16]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-07-08 19:46:16]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1220733007/#ps180001
(title: "mac warning")

[commit-bot: I haz the power, 2015-07-08 19:46:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1220733007/180001

[commit-bot: I haz the power, 2015-07-08 19:54:09]

Committed patchset #9 (id:180001) as
https://skia.googlesource.com/skia/+/81793410a80b1bb147e765caccdd7fb36e34edf8