Cleanup frame description constant.

Cleanup frame description constant.

This unifies the existing frame constants that are the same accross all
architectures. It also adds a new kOriginalConstructorOffset constant
for construct frames and uses is in full-codegen.

R=bmeurer@chromium.org

Committed: https://crrev.com/a104e7c9b4acdfdc7abc9d52b3bd88ff3e87dba1
Cr-Commit-Position: refs/heads/master@{#29509}

[Michael Starzinger, 2015-07-06 18:04:42]

mstarzinger@chromium.org changed reviewers:
+ arv@chromium.org

[Michael Starzinger, 2015-07-06 18:04:43]

Toon: PTAL.
Arv: FYI.

[arv (Not doing code reviews), 2015-07-06 18:14:19]

LGTM

Thanks for taking care of this. It was on my mind as well.

https://codereview.chromium.org/1220223005/diff/1/src/frames.cc
File src/frames.cc (right):

https://codereview.chromium.org/1220223005/diff/1/src/frames.cc#newcode740
src/frames.cc:740: DCHECK_EQ(StandardFrameConstants::kExpressionsOffset - 2 *
kPointerSize,
Can this be a compile time assert instead?

https://codereview.chromium.org/1220223005/diff/1/src/frames.cc#newcode749
src/frames.cc:749: DCHECK_EQ(StandardFrameConstants::kExpressionsOffset - 0 *
kPointerSize,
same

[Michael Starzinger, 2015-07-06 18:20:54]

Addressed comments.

https://codereview.chromium.org/1220223005/diff/1/src/frames.cc
File src/frames.cc (right):

https://codereview.chromium.org/1220223005/diff/1/src/frames.cc#newcode740
src/frames.cc:740: DCHECK_EQ(StandardFrameConstants::kExpressionsOffset - 2 *
kPointerSize,
On 2015/07/06 18:14:19, arv wrote:
> Can this be a compile time assert instead?

Done.

https://codereview.chromium.org/1220223005/diff/1/src/frames.cc#newcode749
src/frames.cc:749: DCHECK_EQ(StandardFrameConstants::kExpressionsOffset - 0 *
kPointerSize,
On 2015/07/06 18:14:19, arv wrote:
> same

Done.

[Benedikt Meurer, 2015-07-07 08:05:24]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2015-07-07 08:05:25]

LGTM. Nice

[Michael Starzinger, 2015-07-07 08:12:08]

mstarzinger@chromium.org changed reviewers:
- verwaest@chromium.org

[Michael Starzinger, 2015-07-07 08:12:22]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2015-07-07 08:12:23]

The patchset sent to the CQ was uploaded after l-g-t-m from arv@chromium.org
Link to the patchset: https://codereview.chromium.org/1220223005/#ps20001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2015-07-07 08:12:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1220223005/20001

[commit-bot: I haz the power, 2015-07-07 08:14:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-07 08:14:43]

Patchset 2 (id:??) landed as
https://crrev.com/a104e7c9b4acdfdc7abc9d52b3bd88ff3e87dba1
Cr-Commit-Position: refs/heads/master@{#29509}