src/ia32/full-codegen-ia32.cc - Issue 1220223005: Cleanup frame description constant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 1220223005: Cleanup frame description constant. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_graph-builder-new-target

Patch Set: Addressed comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index 132a949bd073100cdb68c4a23d323c5220330558..c0df4bc1c006f37ec7df8bf5064def939e0aedbb 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -264,8 +264,8 @@ void FullCodeGenerator::Generate() {

__ j(not_equal, &non_construct_frame);

// Construct frame

- __ mov(eax, Operand(eax, StandardFrameConstants::kExpressionsOffset -

- 2 * kPointerSize));

+ __ mov(eax,

+ Operand(eax, ConstructFrameConstants::kOriginalConstructorOffset));

__ jmp(&done);

// Non-construct frame

« no previous file with comments | « src/ia32/frames-ia32.h ('k') | src/mips/frames-mips.h » ('j') | no next file with comments »