Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1212813008: [turbofan] Port initialization of new.target variable. (Closed)

Created:
5 years, 5 months ago by Michael Starzinger
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Port initialization of new.target variable. This implements the proper initialization of the new.target internal variable in the AstGraphBuilder. For now this uses a runtime call that cannot handle inlined frames correctly. R=arv@chromium.org Committed: https://crrev.com/e2f0bca7781bb885dc3c29c92d6d55dc9d6a91b4 Cr-Commit-Position: refs/heads/master@{#29500}

Patch Set 1 #

Patch Set 2 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -17 lines) Patch
M src/compiler/ast-graph-builder.h View 1 chunk +5 lines, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 3 chunks +28 lines, -15 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/frames.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/frames.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-function.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 5 months ago (2015-07-06 17:15:14 UTC) #1
arv (Not doing code reviews)
LGTM At this point I think we are going to run into issues with deopt ...
5 years, 5 months ago (2015-07-06 17:54:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212813008/20001
5 years, 5 months ago (2015-07-06 18:01:13 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-06 18:02:46 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 18:03:08 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e2f0bca7781bb885dc3c29c92d6d55dc9d6a91b4
Cr-Commit-Position: refs/heads/master@{#29500}

Powered by Google App Engine
This is Rietveld 408576698