src/x64/full-codegen-x64.cc - Issue 1220223005: Cleanup frame description constant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/full-codegen-x64.cc

Issue 1220223005: Cleanup frame description constant. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_graph-builder-new-target

Patch Set: Addressed comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/full-codegen-x64.cc

diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc

index 00a0d8f154080f0e960efce6449bf6ba7f632c27..858fd8167ed57ce3b5b08b5e80d83ff7b004f279 100644

--- a/src/x64/full-codegen-x64.cc

+++ b/src/x64/full-codegen-x64.cc

@@ -261,8 +261,8 @@ void FullCodeGenerator::Generate() {

__ j(not_equal, &non_construct_frame);

// Construct frame

- __ movp(rax, Operand(rax, StandardFrameConstants::kExpressionsOffset -

- 2 * kPointerSize));

+ __ movp(rax,

+ Operand(rax, ConstructFrameConstants::kOriginalConstructorOffset));

__ jmp(&done);

// Non-construct frame

« no previous file with comments | « src/x64/frames-x64.h ('k') | src/x87/frames-x87.h » ('j') | no next file with comments »