src/mips/full-codegen-mips.cc - Issue 1220223005: Cleanup frame description constant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/full-codegen-mips.cc

Issue 1220223005: Cleanup frame description constant. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_graph-builder-new-target

Patch Set: Addressed comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/mips/full-codegen-mips.cc

diff --git a/src/mips/full-codegen-mips.cc b/src/mips/full-codegen-mips.cc

index b9df1e17ecd269fd1531ffc68590598d6eaff7f4..e3331e8868e56aad7199f3a135c94899f8e0c723 100644

--- a/src/mips/full-codegen-mips.cc

+++ b/src/mips/full-codegen-mips.cc

@@ -281,8 +281,8 @@ void FullCodeGenerator::Generate() {

__ Branch(&non_construct_frame, ne, a1,

Operand(Smi::FromInt(StackFrame::CONSTRUCT)));

- __ lw(v0, MemOperand(a2, StandardFrameConstants::kExpressionsOffset -

- 2 * kPointerSize));

+ __ lw(v0,

+ MemOperand(a2, ConstructFrameConstants::kOriginalConstructorOffset));

__ Branch(&done);

__ bind(&non_construct_frame);

« no previous file with comments | « src/mips/frames-mips.h ('k') | src/mips64/frames-mips64.h » ('j') | no next file with comments »