Fix remaining warnings for -Wmissing-braces and enable on win clang.

Fix remaining warnings for -Wmissing-braces and enable on win clang.

Missing braces have been located and restored to their rightful
positions.

BUG=505297
TBR=aboxhall,ananta,atwilson,hajimehoshi,jamiewalch,vitalybuka

Committed: https://crrev.com/5111996850ca220174e6f55350ad1e2d9099dfc6
Cr-Commit-Position: refs/heads/master@{#337781}

[dcheng, 2015-07-01 18:40:32]

dcheng@chromium.org changed reviewers:
+ aboxhall@chromium.org, hajimehoshi@chromium.org

[dcheng, 2015-07-01 18:40:49]

+aboxhall for iaccessible2 changes, +hajimehoshi for cld_2 changes.

[Nico, 2015-07-02 17:22:44]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-07-02 17:22:45]

lgtm, but needs rebasing on top of https://codereview.chromium.org/1214163009/

[dcheng, 2015-07-06 18:00:38]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2015-07-06 18:00:41]

The CQ bit was unchecked by dcheng@chromium.org

[dcheng, 2015-07-06 18:17:26]

Rebased!

TBRing owners since this is a build fix for win clang and thakis@ has reviewed.

[dcheng, 2015-07-06 18:17:42]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2015-07-06 18:17:42]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1216413002/#ps20001
(title: "Rebase?")

[commit-bot: I haz the power, 2015-07-06 18:18:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1216413002/20001

[dcheng, 2015-07-06 18:19:56]

The CQ bit was unchecked by dcheng@chromium.org

[dcheng, 2015-07-06 18:20:18]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2015-07-06 18:20:19]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1216413002/#ps40001
(title: "Moo")

[commit-bot: I haz the power, 2015-07-06 18:22:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1216413002/40001

[Nico, 2015-07-06 18:22:18]

Don't you want to do gyp in the same cl?

[dcheng, 2015-07-06 18:23:16]

On 2015/07/06 at 18:22:18, thakis wrote:
> Don't you want to do gyp in the same cl?

Not really =)

My plan is to enable this for GN builds, and then enable for GYP builds (which
should be a relatively small patch that I can land in one chunk). The only
exceptions were GN/GYP files in third_party repos, since I need to wait for
those changes to roll in.

Sorry, I hate re-gypping on Windows.

[Nico, 2015-07-06 18:24:17]

On Mon, Jul 6, 2015 at 11:23 AM, <dcheng@chromium.org> wrote:

> On 2015/07/06 at 18:22:18, thakis wrote:
>
>> Don't you want to do gyp in the same cl?
>>
>
> Not really =)
>
> My plan is to enable this for GN builds, and then enable for GYP builds
> (which
> should be a relatively small patch that I can land in one chunk). The only
> exceptions were GN/GYP files in third_party repos, since I need to wait for
> those changes to roll in.
>
> Sorry, I hate re-gypping on Windows.
>

Just add it blindly then. Not adding this will need a follow-up for sure,
adding them blindly might not.


>
> https://codereview.chromium.org/1216413002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dcheng, 2015-07-06 18:25:22]

On 2015/07/06 at 18:24:17, thakis wrote:
> On Mon, Jul 6, 2015 at 11:23 AM, <dcheng@chromium.org> wrote:
> 
> > On 2015/07/06 at 18:22:18, thakis wrote:
> >
> >> Don't you want to do gyp in the same cl?
> >>
> >
> > Not really =)
> >
> > My plan is to enable this for GN builds, and then enable for GYP builds
> > (which
> > should be a relatively small patch that I can land in one chunk). The only
> > exceptions were GN/GYP files in third_party repos, since I need to wait for
> > those changes to roll in.
> >
> > Sorry, I hate re-gypping on Windows.
> >
> 
> Just add it blindly then. Not adding this will need a follow-up for sure,
> adding them blindly might not.
> 
> 
> >
> > https://codereview.chromium.org/1216413002/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email to chromium-reviews+unsubscribe@chromium.org.
> 

I still have to re-gyp and experimentally build at least to make sure I don't
break the regular build. I'd rather just do it all in one pass.

[Nico, 2015-07-06 18:58:33]

The CQ bit was unchecked by thakis@chromium.org

[dcheng, 2015-07-08 02:39:09]

PTAL, I just made all the remaining changes needed to make this build.

https://codereview.chromium.org/1216413002/diff/60001/third_party/iaccessible...
File third_party/iaccessible2/BUILD.gn (right):

https://codereview.chromium.org/1216413002/diff/60001/third_party/iaccessible...
third_party/iaccessible2/BUILD.gn:31: configs += [ ":IAccessible2Proxy_warnings"
]
I don't really know why, but the GYP file didn't need any changes.

[Nico, 2015-07-08 02:45:38]

lgtm with one comment:

https://codereview.chromium.org/1216413002/diff/60001/components/policy/core/...
File components/policy/core/common/policy_loader_win.cc (right):

https://codereview.chromium.org/1216413002/diff/60001/components/policy/core/...
components/policy/core/common/policy_loader_win.cc:86: 
Add "// TODO: Remove pragma once http://llvm.org/PR24007 is fixed."

https://codereview.chromium.org/1216413002/diff/60001/third_party/iaccessible...
File third_party/iaccessible2/BUILD.gn (right):

https://codereview.chromium.org/1216413002/diff/60001/third_party/iaccessible...
third_party/iaccessible2/BUILD.gn:31: configs += [ ":IAccessible2Proxy_warnings"
]
On 2015/07/08 02:39:09, dcheng wrote:
> I don't really know why, but the GYP file didn't need any changes.

waaaaat

[dcheng, 2015-07-08 04:35:32]

https://codereview.chromium.org/1216413002/diff/60001/components/policy/core/...
File components/policy/core/common/policy_loader_win.cc (right):

https://codereview.chromium.org/1216413002/diff/60001/components/policy/core/...
components/policy/core/common/policy_loader_win.cc:86: 
On 2015/07/08 at 02:45:38, Nico wrote:
> Add "// TODO: Remove pragma once http://llvm.org/PR24007 is fixed."

Done.

I also had to go through some contortions to make MSVC happy, since it warns
(which is fatal) on unknown pragmas.

Some generated code appears to wrap it in #if IS_A_CLANG_BUILD; I opted to nest
#pragmas...

[Nico, 2015-07-08 05:17:27]

https://codereview.chromium.org/1216413002/diff/80001/components/policy/core/...
File components/policy/core/common/policy_loader_win.cc (right):

https://codereview.chromium.org/1216413002/diff/80001/components/policy/core/...
components/policy/core/common/policy_loader_win.cc:88: #pragma warning(disable:
4068)  // unknown pragmas
alternatively `#ifdef __clang__` i guess.

Do you need the clang diagnostic push if you have warning(push) already? I think
clang might support warning(push) / (pop) in msvc mode (?)

[dcheng, 2015-07-08 08:02:49]

https://codereview.chromium.org/1216413002/diff/80001/components/policy/core/...
File components/policy/core/common/policy_loader_win.cc (right):

https://codereview.chromium.org/1216413002/diff/80001/components/policy/core/...
components/policy/core/common/policy_loader_win.cc:88: #pragma warning(disable:
4068)  // unknown pragmas
On 2015/07/08 at 05:17:27, Nico wrote:
> alternatively `#ifdef __clang__` i guess.
> 
> Do you need the clang diagnostic push if you have warning(push) already? I
think clang might support warning(push) / (pop) in msvc mode (?)

This seems to work. Done.

[dcheng, 2015-07-08 08:05:27]

dcheng@chromium.org changed reviewers:
+ ananta@chromium.org, atwilson@chromium.org, jamiewalch@chromium.org,
vitalybuka@chromium.org

[dcheng, 2015-07-08 08:05:29]

TBRing a couple people

+vitalybuka for cloud_print
+atwilson for components/policy
+jamiewalch for remoting
+ananta for win8

[dcheng, 2015-07-08 08:05:51]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2015-07-08 08:05:52]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1216413002/#ps100001
(title: "Less nesting")

[commit-bot: I haz the power, 2015-07-08 08:06:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1216413002/100001

[commit-bot: I haz the power, 2015-07-08 08:13:10]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-07-08 08:14:10]

Patchset 6 (id:??) landed as
https://crrev.com/5111996850ca220174e6f55350ad1e2d9099dfc6
Cr-Commit-Position: refs/heads/master@{#337781}