Fix remaining warnings for -Wmissing-braces and enable on win clang.

components/policy/core/common/policy_loader_win.cc

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/policy/core/common/policy_loader_win.h"
 
 #include <windows.h>
 #include <lm.h>       // For limits.
 #include <ntdsapi.h>  // For Ds[Un]Bind
 #include <rpc.h>      // For struct GUID
@@ skipping 65 matching lines @@
 // List of policies that are considered only if the user is part of a AD domain.
 // Please document any new additions in policy_templates.json!
 const char* kInsecurePolicies[] = {
     key::kMetricsReportingEnabled,
     key::kDefaultSearchProviderEnabled,
     key::kHomepageIsNewTabPage,
     key::kHomepageLocation,
     key::kRestoreOnStartup,
     key::kRestoreOnStartupURLs
 };
 

[Nico, 2015/07/08 02:45:38]

Add "// TODO: Remove pragma once http://llvm.org/PR24007 is fixed."

[dcheng, 2015/07/08 04:35:32]

Done.

I also had to go through some contortions to make MSVC happy, since it warns
(which is fatal) on unknown pragmas.

Some generated code appears to wrap it in #if IS_A_CLANG_BUILD; I opted to nest
#pragmas...

+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wmissing-braces"
 // The GUID of the registry settings group policy extension.
 GUID kRegistrySettingsCSEGUID = REGISTRY_EXTENSION_GUID;
+#pragma clang diagnostic pop
 
 // The list of possible errors that can occur while collecting information about
 // the current enterprise environment.
 // This enum is used to define the buckets for an enumerated UMA histogram.
 // Hence,
 //   (a) existing enumerated constants should never be deleted or reordered, and
 //   (b) new constants should only be appended at the end of the enumeration.
 enum DomainCheckErrors {
   DOMAIN_CHECK_ERROR_GET_JOIN_INFO = 0,
   DOMAIN_CHECK_ERROR_DS_BIND = 1,
@@ skipping 585 matching lines @@
 
 void PolicyLoaderWin::OnObjectSignaled(HANDLE object) {
   DCHECK(object == user_policy_changed_event_.handle() ||
          object == machine_policy_changed_event_.handle())
       << "unexpected object signaled policy reload, obj = "
       << std::showbase << std::hex << object;
   Reload(false);
 }
 
 }  // namespace policy