Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: third_party/iaccessible2/BUILD.gn

Issue 1216413002: Fix remaining warnings for -Wmissing-braces and enable on win clang. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Less nesting Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/cld_2/cld_2.gyp ('k') | win8/metro_driver/chrome_app_view_ash.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 assert(is_win) 5 assert(is_win)
6 6
7 import("//build/toolchain/win/midl.gni") 7 import("//build/toolchain/win/midl.gni")
8 8
9 midl("iaccessible2") { 9 midl("iaccessible2") {
10 sources = [ 10 sources = [
11 "ia2_api_all.idl", 11 "ia2_api_all.idl",
12 ] 12 ]
13 } 13 }
14 14
15 # Generate a proxy DLL from the generated code. 15 # Generate a proxy DLL from the generated code.
16 shared_library("IAccessible2Proxy") { 16 shared_library("IAccessible2Proxy") {
17 sources = [ 17 sources = [
18 "$target_gen_dir/ia2_api_all.dlldata.c", 18 "$target_gen_dir/ia2_api_all.dlldata.c",
19 "$target_gen_dir/ia2_api_all_p.c", 19 "$target_gen_dir/ia2_api_all_p.c",
20 "IAccessible2Proxy.def", 20 "IAccessible2Proxy.def",
21 ] 21 ]
22 22
23 config("IAccessible2Proxy_warnings") {
24 if (is_clang) {
25 # MIDL generated code has a habit of omitting optional braces.
26 cflags = [ "-Wno-missing-braces" ]
27 }
28 }
23 configs -= [ "//build/config/compiler:chromium_code" ] 29 configs -= [ "//build/config/compiler:chromium_code" ]
24 configs += [ "//build/config/compiler:no_chromium_code" ] 30 configs += [ "//build/config/compiler:no_chromium_code" ]
31 configs += [ ":IAccessible2Proxy_warnings" ]
25 32
26 defines = [ "REGISTER_PROXY_DLL" ] 33 defines = [ "REGISTER_PROXY_DLL" ]
27 34
28 libs = [ "rpcrt4.lib" ] 35 libs = [ "rpcrt4.lib" ]
29 36
30 deps = [ 37 deps = [
31 ":iaccessible2", 38 ":iaccessible2",
32 ] 39 ]
33 } 40 }
OLDNEW
« no previous file with comments | « third_party/cld_2/cld_2.gyp ('k') | win8/metro_driver/chrome_app_view_ash.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698