Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: third_party/iaccessible2/BUILD.gn

Issue 1216413002: Fix remaining warnings for -Wmissing-braces and enable on win clang. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Less nesting Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/cld_2/cld_2.gyp ('k') | win8/metro_driver/chrome_app_view_ash.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/iaccessible2/BUILD.gn
diff --git a/third_party/iaccessible2/BUILD.gn b/third_party/iaccessible2/BUILD.gn
index 6ebcee644d3d0c166e4fefc5a5a73e1de95f5892..902667464257dfef2b771b02e4112a2cd6fe80e9 100644
--- a/third_party/iaccessible2/BUILD.gn
+++ b/third_party/iaccessible2/BUILD.gn
@@ -20,8 +20,15 @@ shared_library("IAccessible2Proxy") {
"IAccessible2Proxy.def",
]
+ config("IAccessible2Proxy_warnings") {
+ if (is_clang) {
+ # MIDL generated code has a habit of omitting optional braces.
+ cflags = [ "-Wno-missing-braces" ]
+ }
+ }
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
+ configs += [ ":IAccessible2Proxy_warnings" ]
defines = [ "REGISTER_PROXY_DLL" ]
« no previous file with comments | « third_party/cld_2/cld_2.gyp ('k') | win8/metro_driver/chrome_app_view_ash.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698