cloud_print/service/win/service.gyp - Issue 1216413002: Fix remaining warnings for -Wmissing-braces and enable on win clang.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/service/win/service.gyp

Issue 1216413002: Fix remaining warnings for -Wmissing-braces and enable on win clang. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Less nesting Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cloud_print/service/win/service.gyp

diff --git a/cloud_print/service/win/service.gyp b/cloud_print/service/win/service.gyp

index e8ff6248ff6773e1aadbafd4b6ac2b11baf599b1..0019b6f1ca913ae6f19322a100aa4f311c1fe8ad 100644

--- a/cloud_print/service/win/service.gyp

+++ b/cloud_print/service/win/service.gyp

@@ -88,17 +88,15 @@

'-Wno-header-hygiene',

# atlgdi.h does an intentional assignment in an if conditional.

'-Wno-parentheses',

+ # atlgdi.h fails with -Wreorder enabled.

+ '-Wno-reorder',

+ # atlgdi.h doesn't use braces around subobject initializers.

+ '-Wno-missing-braces',

}],

- 'variables': {

- 'clang_warning_flags': [

- # atlgdi.h fails with -Wreorder enabled.

- '-Wno-reorder',

- ]

- },

{

'target_name': 'cloud_print_service_setup',

« no previous file with comments | « chrome/installer/gcapi/gcapi.cc ('k') | components/policy/core/common/policy_loader_win.cc » ('j') | no next file with comments »