Remove -Wno-unused-private-field clang warning suppression.

Remove -Wno-unused-private-field clang warning suppression.

BUG=505317
Committed: https://crrev.com/ef1895a8c18b7e8055ec7b480073f75125dbb705
Cr-Commit-Position: refs/heads/master@{#338115}

[benwells, 2015-07-07 11:38:27]

The CQ bit was checked by benwells@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-07 11:38:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1215643003/1

[commit-bot: I haz the power, 2015-07-07 12:42:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-07 12:42:19]

Dry run: This issue passed the CQ dry run.

[benwells, 2015-07-09 01:43:37]

benwells@chromium.org changed reviewers:
+ thakis@chromium.org

[benwells, 2015-07-09 01:43:37]

Not sure if I did the GN / gyp files correctly.

[Nico, 2015-07-09 01:58:17]

cool, lgtm!

I think the gyp/gn stuff is correct. If you want to be cautious, you can `git cl
try -b win_clang_rel; git cl try -b win_clang_x64_dbg` since today. (The second
bot had a hiccup that I think I've fixed, but I haven't checked the fix.) There
are only 3 slaves for these bots and the jobs take 2h to run, so don't send many
jobs though. And you can just land as well and use the fyi bots.

https://codereview.chromium.org/1215643003/diff/20001/content/browser/rendere...
File content/browser/renderer_host/media/video_capture_buffer_pool.cc (right):

https://codereview.chromium.org/1215643003/diff/20001/content/browser/rendere...
content/browser/renderer_host/media/video_capture_buffer_pool.cc:45: const
base::SharedMemoryHandle handle_;
nit: It's strange to have data_ and size_ not next to each other (I get that the
ifdef is a bit nicer this way, but meh)

https://codereview.chromium.org/1215643003/diff/20001/media/audio/win/audio_o...
File media/audio/win/audio_output_win_unittest.cc (right):

https://codereview.chromium.org/1215643003/diff/20001/media/audio/win/audio_o...
media/audio/win/audio_output_win_unittest.cc:83: TestSourceLaggy(int lag_in_ms)
explicit

https://codereview.chromium.org/1215643003/diff/20001/third_party/cld_2/BUILD.gn
File third_party/cld_2/BUILD.gn (right):

https://codereview.chromium.org/1215643003/diff/20001/third_party/cld_2/BUILD...
third_party/cld_2/BUILD.gn:79: # hunspell has unused private fields.
s/hunspell/cld_2/

https://codereview.chromium.org/1215643003/diff/20001/third_party/cld_2/cld_2...
File third_party/cld_2/cld_2.gyp (right):

https://codereview.chromium.org/1215643003/diff/20001/third_party/cld_2/cld_2...
third_party/cld_2/cld_2.gyp:164: 'clang_warning_flags': [
Are the fields windows-specific somehow? If not, move the variables section out
(so that it's next to 'sources' like in hunspell.gyp). If it's Windows-specific,
you don't really need to use clang_warning_flags but can use
msvs_settings/VCCLCompilerTool/AdditionalOptions (if clang==1) – the point of
clang_warning_flags is that it puts it into the right places on all platforms
(...VCCLCompilerTool... on win, xcode_settings... on mac, cflags elsewhere). I'm
guessing it's not Windows-specific and just happens to only fire on Windows
because third-party code builds with -Wall on Windows but not (yet?) elsewhere

[benwells, 2015-07-09 11:43:02]

benwells@chromium.org changed reviewers:
+ brettw@chromium.org

[benwells, 2015-07-09 11:43:02]

+brettw for owners

https://codereview.chromium.org/1215643003/diff/20001/content/browser/rendere...
File content/browser/renderer_host/media/video_capture_buffer_pool.cc (right):

https://codereview.chromium.org/1215643003/diff/20001/content/browser/rendere...
content/browser/renderer_host/media/video_capture_buffer_pool.cc:45: const
base::SharedMemoryHandle handle_;
On 2015/07/09 01:58:16, Nico wrote:
> nit: It's strange to have data_ and size_ not next to each other (I get that
the
> ifdef is a bit nicer this way, but meh)

Done.

https://codereview.chromium.org/1215643003/diff/20001/media/audio/win/audio_o...
File media/audio/win/audio_output_win_unittest.cc (right):

https://codereview.chromium.org/1215643003/diff/20001/media/audio/win/audio_o...
media/audio/win/audio_output_win_unittest.cc:83: TestSourceLaggy(int lag_in_ms)
On 2015/07/09 01:58:16, Nico wrote:
> explicit

Done.

https://codereview.chromium.org/1215643003/diff/20001/third_party/cld_2/BUILD.gn
File third_party/cld_2/BUILD.gn (right):

https://codereview.chromium.org/1215643003/diff/20001/third_party/cld_2/BUILD...
third_party/cld_2/BUILD.gn:79: # hunspell has unused private fields.
On 2015/07/09 01:58:16, Nico wrote:
> s/hunspell/cld_2/

oops, done.

https://codereview.chromium.org/1215643003/diff/20001/third_party/cld_2/cld_2...
File third_party/cld_2/cld_2.gyp (right):

https://codereview.chromium.org/1215643003/diff/20001/third_party/cld_2/cld_2...
third_party/cld_2/cld_2.gyp:164: 'clang_warning_flags': [
On 2015/07/09 01:58:16, Nico wrote:
> Are the fields windows-specific somehow? If not, move the variables section
out
> (so that it's next to 'sources' like in hunspell.gyp). If it's
Windows-specific,
> you don't really need to use clang_warning_flags but can use
> msvs_settings/VCCLCompilerTool/AdditionalOptions (if clang==1) – the point of
> clang_warning_flags is that it puts it into the right places on all platforms
> (...VCCLCompilerTool... on win, xcode_settings... on mac, cflags elsewhere).
I'm
> guessing it's not Windows-specific and just happens to only fire on Windows
> because third-party code builds with -Wall on Windows but not (yet?) elsewhere

Ah, not windows specific. Moved out from this.

[brettw, 2015-07-09 18:03:07]

LGTM, just some GN style nits.

https://codereview.chromium.org/1215643003/diff/60001/third_party/cld_2/BUILD.gn
File third_party/cld_2/BUILD.gn (right):

https://codereview.chromium.org/1215643003/diff/60001/third_party/cld_2/BUILD...
third_party/cld_2/BUILD.gn:106: ":cld2_warnings",
This should go first.

https://codereview.chromium.org/1215643003/diff/60001/third_party/cld_2/BUILD...
third_party/cld_2/BUILD.gn:126: ":cld2_warnings",
Ditto

https://codereview.chromium.org/1215643003/diff/60001/third_party/hunspell/BU...
File third_party/hunspell/BUILD.gn (right):

https://codereview.chromium.org/1215643003/diff/60001/third_party/hunspell/BU...
third_party/hunspell/BUILD.gn:54: config("hunspell_warnings") {
This should go at the top (don't nest targets).

https://codereview.chromium.org/1215643003/diff/60001/third_party/hunspell/BU...
third_party/hunspell/BUILD.gn:63: ":hunspell_warnings",
Ditto

[Nico, 2015-07-09 18:18:46]

https://codereview.chromium.org/1215643003/diff/60001/third_party/cld_2/BUILD.gn
File third_party/cld_2/BUILD.gn (right):

https://codereview.chromium.org/1215643003/diff/60001/third_party/cld_2/BUILD...
third_party/cld_2/BUILD.gn:106: ":cld2_warnings",
On 2015/07/09 18:03:07, brettw wrote:
> This should go first.

No, it needs be be after no_chromium_code so that the -Wno flag is after the
(effective) -Wall in no_chromium_code (that's why there's a config for this).

https://codereview.chromium.org/1215643003/diff/60001/third_party/cld_2/BUILD...
third_party/cld_2/BUILD.gn:126: ":cld2_warnings",
On 2015/07/09 18:03:07, brettw wrote:
> Ditto

Ditto.

https://codereview.chromium.org/1215643003/diff/60001/third_party/hunspell/BU...
File third_party/hunspell/BUILD.gn (right):

https://codereview.chromium.org/1215643003/diff/60001/third_party/hunspell/BU...
third_party/hunspell/BUILD.gn:54: config("hunspell_warnings") {
On 2015/07/09 18:03:07, brettw wrote:
> This should go at the top (don't nest targets).

Almost all of the -Wno targets are nested.
(https://code.google.com/p/chromium/codesearch#search/&q=pcre:yes%20config.*%5...
– that doesn't find all, but some)

[Nico, 2015-07-09 18:18:54]

The CQ bit was checked by thakis@chromium.org

[Nico, 2015-07-09 18:18:54]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1215643003/#ps60001
(title: "Feedback")

[commit-bot: I haz the power, 2015-07-09 18:20:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1215643003/60001

[commit-bot: I haz the power, 2015-07-09 19:33:36]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-09 19:35:49]

Patchset 4 (id:??) landed as
https://crrev.com/ef1895a8c18b7e8055ec7b480073f75125dbb705
Cr-Commit-Position: refs/heads/master@{#338115}

[benwells, 2015-07-10 00:17:44]

https://codereview.chromium.org/1215643003/diff/60001/third_party/hunspell/BU...
File third_party/hunspell/BUILD.gn (right):

https://codereview.chromium.org/1215643003/diff/60001/third_party/hunspell/BU...
third_party/hunspell/BUILD.gn:54: config("hunspell_warnings") {
On 2015/07/09 18:18:46, Nico wrote:
> On 2015/07/09 18:03:07, brettw wrote:
> > This should go at the top (don't nest targets).
> 
> Almost all of the -Wno targets are nested.
>
(https://code.google.com/p/chromium/codesearch#search/&q=pcre:yes%20config.*%5...
> – that doesn't find all, but some)

So this got landed as is in my sleep-time. I am happy to unnest if that is the
right thing to do in a follow up. Let me know if I should.

[benwells, 2015-07-10 00:17:44]

https://codereview.chromium.org/1215643003/diff/60001/third_party/hunspell/BU...
File third_party/hunspell/BUILD.gn (right):

https://codereview.chromium.org/1215643003/diff/60001/third_party/hunspell/BU...
third_party/hunspell/BUILD.gn:54: config("hunspell_warnings") {
On 2015/07/09 18:18:46, Nico wrote:
> On 2015/07/09 18:03:07, brettw wrote:
> > This should go at the top (don't nest targets).
> 
> Almost all of the -Wno targets are nested.
>
(https://code.google.com/p/chromium/codesearch#search/&q=pcre:yes%20config.*%5...
> – that doesn't find all, but some)

So this got landed as is in my sleep-time. I am happy to unnest if that is the
right thing to do in a follow up. Let me know if I should.