Remove -Wno-unused-private-field clang warning suppression.

third_party/cld_2/cld_2.gyp

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # MAINTAINERS:
 # See the BUILD.gn file for more extensive comments and documentation. This
 # .gyp file exists only for compatibility with gyp. The variables defined below
 # are used in equivalent targets in BUILD.GN.
 
 {
@@ skipping 142 matching lines @@
         'src/public',
       ],
       'sources': [
         '<@(cld2_core_sources)',
         '<@(cld2_core_impl_sources)',
         '<@(cld2_data_sources)',
       ],
       'conditions': [
         ['OS=="win"', {
           'msvs_disabled_warnings': [4267], # size_t -> int conversion.
+          'variables': {
+            'clang_warning_flags': [

[Nico, 2015/07/09 01:58:16]

Are the fields windows-specific somehow? If not, move the variables section out
(so that it's next to 'sources' like in hunspell.gyp). If it's Windows-specific,
you don't really need to use clang_warning_flags but can use
msvs_settings/VCCLCompilerTool/AdditionalOptions (if clang==1) – the point of
clang_warning_flags is that it puts it into the right places on all platforms
(...VCCLCompilerTool... on win, xcode_settings... on mac, cflags elsewhere). I'm
guessing it's not Windows-specific and just happens to only fire on Windows
because third-party code builds with -Wall on Windows but not (yet?) elsewhere

[benwells, 2015/07/09 11:43:02]

Ah, not windows specific. Moved out from this.

+              # cld_2 contains unused private fields.
+              '-Wno-unused-private-field',
+            ],
+          },
         }],
         ['cld2_table_size==0', {
           'sources+': ['<@(cld2_data_smallest_sources)']
         }],
         ['cld2_table_size==2', {
           'sources+': ['<@(cld2_data_largest_sources)']
         }],
       ],
     },
 
@@ skipping 12 matching lines @@
       ],
       'sources': [
         '<@(cld2_core_sources)',
         '<@(cld2_core_impl_sources)',
         '<@(cld2_dynamic_data_loader_sources)',
       ],
       'defines': ['CLD2_DYNAMIC_MODE'],
     },
   ],
 }