Remove -Wno-unused-private-field clang warning suppression.

third_party/cld_2/BUILD.gn

Index: third_party/cld_2/BUILD.gn
diff --git a/third_party/cld_2/BUILD.gn b/third_party/cld_2/BUILD.gn
index a401bcc7e7040653029ec3681fa5c991b711329f..9789c763db48ba8a6745290d31d2ce16edf38843 100644
--- a/third_party/cld_2/BUILD.gn
+++ b/third_party/cld_2/BUILD.gn
@@ -80,6 +80,15 @@ source_set("cld2_platform_impl") {
   }
 }
 
+config("cld2_warnings") {
+  if (is_clang) {
+    cflags = [
+      # cld_2 has unused private fields.
+      "-Wno-unused-private-field",
+    ]
+  }
+}
+
 static_library("cld2_static") {
   sources = gypi_values.cld2_core_impl_sources
   include_dirs = [
@@ -92,7 +101,10 @@ static_library("cld2_static") {
     ":cld2_data",
   ]
   configs -= [ "//build/config/compiler:chromium_code" ]
-  configs += [ "//build/config/compiler:no_chromium_code" ]
+  configs += [
+    "//build/config/compiler:no_chromium_code",
+    ":cld2_warnings",

[brettw, 2015/07/09 18:03:07]

This should go first.

[Nico, 2015/07/09 18:18:46]

No, it needs be be after no_chromium_code so that the -Wno flag is after the
(effective) -Wall in no_chromium_code (that's why there's a config for this).

+  ]
 }
 
 config("cld2_dynamic_mode_config") {
@@ -111,6 +123,7 @@ static_library("cld2_dynamic") {
   configs += [
     ":cld2_dynamic_mode_config",
     "//build/config/compiler:no_chromium_code",
+    ":cld2_warnings",

[brettw, 2015/07/09 18:03:07]

Ditto

[Nico, 2015/07/09 18:18:46]

Ditto.

   ]
 }