Remove -Wno-unused-private-field clang warning suppression.

third_party/hunspell/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 config("hunspell_config") {
   defines = [
     "HUNSPELL_STATIC",
     "HUNSPELL_CHROME_CLIENT",
     "USE_HUNSPELL",
   ]
@@ skipping 33 matching lines @@
     "src/hunspell/replist.cxx",
     "src/hunspell/replist.hxx",
     "src/hunspell/suggestmgr.cxx",
     "src/hunspell/suggestmgr.hxx",
     "src/hunspell/utf_info.hxx",
     "src/hunspell/w_char.hxx",
     "src/parsers/textparser.cxx",
     "src/parsers/textparser.hxx",
   ]
 
+  config("hunspell_warnings") {

[brettw, 2015/07/09 18:03:07]

This should go at the top (don't nest targets).

[Nico, 2015/07/09 18:18:46]

Almost all of the -Wno targets are nested.
(https://code.google.com/p/chromium/codesearch#search/&q=pcre:yes%20config.*%5...
– that doesn't find all, but some)

[benwells, 2015/07/10 00:17:44]

So this got landed as is in my sleep-time. I am happy to unnest if that is the
right thing to do in a follow up. Let me know if I should.

+    if (is_clang) {
+      cflags = [ "-Wno-unused-private-field" ]
+    }
+  }
+
   configs -= [ "//build/config/compiler:chromium_code" ]
-  configs += [ "//build/config/compiler:no_chromium_code" ]
+  configs += [
+    "//build/config/compiler:no_chromium_code",
+    ":hunspell_warnings",

[brettw, 2015/07/09 18:03:07]

Ditto

+  ]
   public_configs = [ ":hunspell_config" ]
 
   defines = [ "OPENOFFICEORG" ]
 
   deps = [
     "//base",
     "//third_party/icu",
   ]
 
   cflags = []
@@ skipping 25 matching lines @@
     cflags += [
       # affentry.cxx has one `while ((p = nextchar(p)));` parsing loop.
       "-Wno-empty-body",
 
       # affentry.hxx has NULL as default parameter for a FLAG in two
       # places.
       "-Wno-null-conversion",
     ]
   }
 }