Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: media/audio/win/audio_output_win_unittest.cc

Issue 1215643003: Remove -Wno-unused-private-field clang warning suppression. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/win/audio_output_win_unittest.cc
diff --git a/media/audio/win/audio_output_win_unittest.cc b/media/audio/win/audio_output_win_unittest.cc
index 3ce3df3c56889f3a3609dcbc147b63cabab014fb..68f61eaf4d7395b3b91e4074e7f8fe150778e4be 100644
--- a/media/audio/win/audio_output_win_unittest.cc
+++ b/media/audio/win/audio_output_win_unittest.cc
@@ -41,7 +41,7 @@ static int ClearData(AudioBus* audio_bus, uint32 total_bytes_delay) {
// expected and if any error has been reported.
class TestSourceBasic : public AudioOutputStream::AudioSourceCallback {
public:
- explicit TestSourceBasic()
+ TestSourceBasic()
: callback_count_(0),
had_error_(0) {
}
@@ -77,8 +77,8 @@ const int kMaxNumBuffers = 3;
// in the OnMoreData callback.
class TestSourceLaggy : public TestSourceBasic {
public:
- TestSourceLaggy(int laggy_after_buffer, int lag_in_ms)
- : laggy_after_buffer_(laggy_after_buffer), lag_in_ms_(lag_in_ms) {
+ explicit TestSourceLaggy(int lag_in_ms)
+ : lag_in_ms_(lag_in_ms) {
}
int OnMoreData(AudioBus* audio_bus, uint32 total_bytes_delay) override {
// Call the base, which increments the callback_count_.
@@ -89,7 +89,6 @@ class TestSourceLaggy : public TestSourceBasic {
return audio_bus->frames();
}
private:
- int laggy_after_buffer_;
int lag_in_ms_;
};
@@ -235,7 +234,7 @@ TEST(WinAudioTest, PCMWaveSlowSource) {
16000, 16, 256),
std::string());
ASSERT_TRUE(NULL != oas);
- TestSourceLaggy test_laggy(2, 90);
+ TestSourceLaggy test_laggy(90);
EXPECT_TRUE(oas->Open());
// The test parameters cause a callback every 32 ms and the source is
// sleeping for 90 ms, so it is guaranteed that we run out of ready buffers.

Powered by Google App Engine
This is Rietveld 408576698