Remove NAVIGATION_TYPE_IN_PAGE.

Remove NAVIGATION_TYPE_IN_PAGE.

BUG=251330
TEST=all tests should stay green

Committed: https://crrev.com/259dc79058886a5b109ff65431bc1a19e854469e
Cr-Commit-Position: refs/heads/master@{#337562}

[Avi (use Gerrit), 2015-07-06 23:16:49]

avi@chromium.org changed reviewers:
+ creis@chromium.org, samarth@chromium.org

[Avi (use Gerrit), 2015-07-06 23:16:50]

samarth@: You filed the bug two years ago, you get the review :) Search tab,
please.
creis@: The rest.

[Charlie Reis, 2015-07-07 00:07:15]

Nice.  LGTM.

https://codereview.chromium.org/1214073005/diff/40001/content/browser/frame_h...
File content/browser/frame_host/navigation_controller_impl.cc (left):

https://codereview.chromium.org/1214073005/diff/40001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl.cc:1234: void
NavigationControllerImpl::RendererDidNavigateInPage(
Wow, this is all handled by RendererDidNavigateToExistingPage already, isn't it?
 I would have expected there to be some difference to account for, but the extra
tasks that one does don't seem to be an issue.  Having one fewer case to account
for is nice.

[samarth, 2015-07-07 00:39:32]

lgtm

Thanks for fixing this!

[Avi (use Gerrit), 2015-07-07 04:38:16]

https://codereview.chromium.org/1214073005/diff/40001/content/browser/frame_h...
File content/browser/frame_host/navigation_controller_impl.cc (left):

https://codereview.chromium.org/1214073005/diff/40001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl.cc:1234: void
NavigationControllerImpl::RendererDidNavigateInPage(
On 2015/07/07 00:07:15, Charlie Reis wrote:
> Wow, this is all handled by RendererDidNavigateToExistingPage already, isn't
it?
>  I would have expected there to be some difference to account for, but the
extra
> tasks that one does don't seem to be an issue.  Having one fewer case to
account
> for is nice.

Yes. The only real difference is setting the did_replace_entry but I moved that
to RDN.

Less identical code, check.

[Avi (use Gerrit), 2015-07-07 04:38:22]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2015-07-07 04:38:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1214073005/40001

[commit-bot: I haz the power, 2015-07-07 04:42:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-07 04:43:45]

Patchset 3 (id:??) landed as
https://crrev.com/259dc79058886a5b109ff65431bc1a19e854469e
Cr-Commit-Position: refs/heads/master@{#337562}