content/browser/frame_host/navigation_controller_impl_unittest.cc - Issue 1214073005: Remove NAVIGATION_TYPE_IN_PAGE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl_unittest.cc

Issue 1214073005: Remove NAVIGATION_TYPE_IN_PAGE. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: didreplace Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_controller_impl_unittest.cc

diff --git a/content/browser/frame_host/navigation_controller_impl_unittest.cc b/content/browser/frame_host/navigation_controller_impl_unittest.cc

index 1520c031a50a64ac69c377addf9f26fb664ee273..2d7fc1cd7d630dbac384a09e439bc650c59429d3 100644

--- a/content/browser/frame_host/navigation_controller_impl_unittest.cc

+++ b/content/browser/frame_host/navigation_controller_impl_unittest.cc

@@ -4943,7 +4943,7 @@ TEST_F(NavigationControllerTest, UnreachableURLGivesErrorPage) {

controller_impl().RendererDidNavigate(main_test_rfh(), params, &details);

EXPECT_EQ(PAGE_TYPE_ERROR,

controller_impl().GetLastCommittedEntry()->GetPageType());

- EXPECT_EQ(NAVIGATION_TYPE_IN_PAGE, details.type);

+ EXPECT_TRUE(details.is_in_page);

}