content/browser/android/web_contents_observer_proxy.cc - Issue 1214073005: Remove NAVIGATION_TYPE_IN_PAGE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/web_contents_observer_proxy.cc

Issue 1214073005: Remove NAVIGATION_TYPE_IN_PAGE. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: didreplace Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/android/web_contents_observer_proxy.cc

diff --git a/content/browser/android/web_contents_observer_proxy.cc b/content/browser/android/web_contents_observer_proxy.cc

index c4cb1b726bb65dde2cb165ab40113008b3d36d84..9d82f17f0c96cffaa3a7dc87f9e94989f285d314 100644

--- a/content/browser/android/web_contents_observer_proxy.cc

+++ b/content/browser/android/web_contents_observer_proxy.cc

@@ -133,8 +133,7 @@ void WebContentsObserverProxy::DidNavigateMainFrame(

// is actually a fragment navigation, or a history API navigation to a URL

// that would also be valid for a fragment navigation.

bool is_fragment_navigation =

- urls_same_ignoring_fragment &&

- (details.type == NAVIGATION_TYPE_IN_PAGE || details.is_in_page);

+ urls_same_ignoring_fragment && details.is_in_page;

Java_WebContentsObserverProxy_didNavigateMainFrame(

env, obj.obj(), jstring_url.obj(), jstring_base_url.obj(),

details.is_navigation_to_different_page(), is_fragment_navigation,