Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6082)

Unified Diff: chrome/browser/ui/search/search_tab_helper.cc

Issue 1214073005: Remove NAVIGATION_TYPE_IN_PAGE. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: didreplace Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/search_tab_helper.cc
diff --git a/chrome/browser/ui/search/search_tab_helper.cc b/chrome/browser/ui/search/search_tab_helper.cc
index 04cef26e7797f504dbc77f308b806965c4d5cde8..7fce7b7954ed183f7f4bb5169f8841c7e14e7e57 100644
--- a/chrome/browser/ui/search/search_tab_helper.cc
+++ b/chrome/browser/ui/search/search_tab_helper.cc
@@ -357,16 +357,7 @@ void SearchTabHelper::NavigationEntryCommitted(
// Already determined the instant support state for this page, do not reset
// the instant support state.
- //
- // When we get a navigation entry committed event, there seem to be two ways
- // to tell whether the navigation was "in-page". Ideally, when
- // LoadCommittedDetails::is_in_page is true, we should have
- // LoadCommittedDetails::type to be NAVIGATION_TYPE_IN_PAGE. Unfortunately,
- // they are different in some cases. To workaround this bug, we are checking
- // (is_in_page || type == NAVIGATION_TYPE_IN_PAGE). Please refer to
- // crbug.com/251330 for more details.
- if (load_details.is_in_page ||
- load_details.type == content::NAVIGATION_TYPE_IN_PAGE) {
+ if (load_details.is_in_page) {
// When an "in-page" navigation happens, we will not receive a
// DidFinishLoad() event. Therefore, we will not determine the Instant
// support for the navigated page. So, copy over the Instant support from

Powered by Google App Engine
This is Rietveld 408576698