Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: content/public/browser/navigation_type.h

Issue 1214073005: Remove NAVIGATION_TYPE_IN_PAGE. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: didreplace Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_TYPE_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_TYPE_H_
6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_TYPE_H_ 6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_TYPE_H_
7 7
8 namespace content { 8 namespace content {
9 9
10 // Indicates different types of navigations that can occur that we will handle 10 // Indicates different types of navigations that can occur that we will handle
(...skipping 12 matching lines...) Expand all
23 // Renavigating to an existing navigation entry. This is the case for history 23 // Renavigating to an existing navigation entry. This is the case for history
24 // navigation, reloads, and location.replace(). 24 // navigation, reloads, and location.replace().
25 NAVIGATION_TYPE_EXISTING_PAGE, 25 NAVIGATION_TYPE_EXISTING_PAGE,
26 26
27 // The same page has been reloaded as a result of the user requesting 27 // The same page has been reloaded as a result of the user requesting
28 // navigation to that same page (like pressing Enter in the URL bar). This 28 // navigation to that same page (like pressing Enter in the URL bar). This
29 // is not the same as an in-page navigation because we'll actually have a 29 // is not the same as an in-page navigation because we'll actually have a
30 // pending entry for the load, which is then meaningless. 30 // pending entry for the load, which is then meaningless.
31 NAVIGATION_TYPE_SAME_PAGE, 31 NAVIGATION_TYPE_SAME_PAGE,
32 32
33 // The navigation was in the main frame, to a different navigation entry, but
34 // appearing to the user to be a navigation within the same page. This is the
35 // case for history.replaceState(), as well as back and forward across
36 // fragment entries and history.pushState() entries.
37 NAVIGATION_TYPE_IN_PAGE,
38
39 // A new subframe was manually navigated by the user. We will create a new 33 // A new subframe was manually navigated by the user. We will create a new
40 // NavigationEntry so they can go back to the previous subframe content 34 // NavigationEntry so they can go back to the previous subframe content
41 // using the back button. 35 // using the back button.
42 NAVIGATION_TYPE_NEW_SUBFRAME, 36 NAVIGATION_TYPE_NEW_SUBFRAME,
43 37
44 // A subframe in the page was automatically loaded or navigated to such that 38 // A subframe in the page was automatically loaded or navigated to such that
45 // a new navigation entry should not be created. There are two cases: 39 // a new navigation entry should not be created. There are two cases:
46 // 1. Stuff like iframes containing ads that the page loads automatically. 40 // 1. Stuff like iframes containing ads that the page loads automatically.
47 // The user doesn't want to see these, so we just update the existing 41 // The user doesn't want to see these, so we just update the existing
48 // navigation entry. 42 // navigation entry.
49 // 2. Going back/forward to previous subframe navigations. We don't create 43 // 2. Going back/forward to previous subframe navigations. We don't create
50 // a new entry here either, just update the last committed entry. 44 // a new entry here either, just update the last committed entry.
51 // These two cases are actually pretty different, they just happen to 45 // These two cases are actually pretty different, they just happen to
52 // require almost the same code to handle. 46 // require almost the same code to handle.
53 NAVIGATION_TYPE_AUTO_SUBFRAME, 47 NAVIGATION_TYPE_AUTO_SUBFRAME,
54 48
55 // Nothing happened. This happens when we get information about a page we 49 // Nothing happened. This happens when we get information about a page we
56 // don't know anything about. It can also happen when an iframe in a popup 50 // don't know anything about. It can also happen when an iframe in a popup
57 // navigated to about:blank is navigated. Nothing needs to be done. 51 // navigated to about:blank is navigated. Nothing needs to be done.
58 NAVIGATION_TYPE_NAV_IGNORE, 52 NAVIGATION_TYPE_NAV_IGNORE,
59 }; 53 };
60 54
61 } // namespace content 55 } // namespace content
62 56
63 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_TYPE_H_ 57 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_TYPE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698