Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1203793003: Remove flip_y, premultiply_alpha, unmultiply_alpha support in command buffer. (Closed)

Created:
5 years, 6 months ago by Zhenyao Mo
Modified:
5 years, 6 months ago
Reviewers:
bbudge, DaleCurtis, piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, extensions-reviews_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org, wjia+watch_chromium.org, mlamouri+watch-media_chromium.org, Ken Russell (switch to Gerrit), bajones, vmiura, no sievers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove flip_y, premultiply_alpha, unmultiply_alpha support in command buffer. Except for client side PixelStorei, but it is an NO_OP for now. BUG=502491 TEST=gpu bots R=piman@chromium.org,dalecurtis@chromium.org NOPRESUBMIT=true Committed: https://crrev.com/2af27243cc33cf99c27b50b4552090140ce257e7 Cr-Commit-Position: refs/heads/master@{#335957}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -731 lines) Patch
M content/renderer/media/android/webmediaplayer_android.cc View 1 3 chunks +5 lines, -21 lines 0 comments Download
D gpu/GLES2/extensions/CHROMIUM/CHROMIUM_flipy.txt View 1 chunk +0 lines, -118 lines 0 comments Download
M gpu/blink/webgraphicscontext3d_impl.h View 1 2 3 chunks +2 lines, -20 lines 0 comments Download
M gpu/blink/webgraphicscontext3d_impl.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 2 chunks +0 lines, -6 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 11 chunks +12 lines, -24 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 13 chunks +71 lines, -209 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 2 chunks +0 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 6 chunks +0 lines, -49 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 2 chunks +0 lines, -6 lines 0 comments Download
M gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc View 1 chunk +0 lines, -201 lines 0 comments Download
M media/blink/skcanvas_video_renderer.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/lib/gl/include/GLES2/gl2ext.h View 1 2 3 2 chunks +44 lines, -31 lines 0 comments Download
M ui/gl/gl_bindings.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Zhenyao Mo
piman: PTAL dalecurtis: media OWNER bbudge: ppapi OWNER
5 years, 6 months ago (2015-06-23 22:27:49 UTC) #2
Zhenyao Mo
Note that this CL is pending on https://codereview.chromium.org/1207483004/ landing and being rolled into Chrome.
5 years, 6 months ago (2015-06-23 22:28:52 UTC) #3
DaleCurtis
media/ lgtm
5 years, 6 months ago (2015-06-24 00:28:43 UTC) #4
bbudge
ppapi LGTM
5 years, 6 months ago (2015-06-24 00:40:54 UTC) #5
piman
lgtm
5 years, 6 months ago (2015-06-24 02:42:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203793003/40001
5 years, 6 months ago (2015-06-24 16:27:58 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/73617)
5 years, 6 months ago (2015-06-24 16:37:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203793003/80001
5 years, 6 months ago (2015-06-24 18:24:30 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 6 months ago (2015-06-24 18:27:13 UTC) #16
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 18:28:16 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2af27243cc33cf99c27b50b4552090140ce257e7
Cr-Commit-Position: refs/heads/master@{#335957}

Powered by Google App Engine
This is Rietveld 408576698