Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 1207483004: Pass flipY and premultiplyAlpha params to command buffer through func args. (Closed)

Created:
5 years, 6 months ago by Zhenyao Mo
Modified:
5 years, 6 months ago
CC:
blink-reviews, krit, drott+blinkwatch_chromium.org, Rik, dshwang, jbroman, Justin Novosad, danakj, dglazkov+blink, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Pass flipY and premultiplyAlpha params to command buffer through func args. Note that we can't get rid of the pixelStorei calls yet. BUG=502491 TEST=gpu bots R=kbr@chromium.org, japhet@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197702

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M Source/platform/graphics/ImageBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/gpu/DrawingBuffer.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M public/platform/WebGraphicsContext3D.h View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
Zhenyao Mo
Ken: please review Nate: public/ OWNER review
5 years, 6 months ago (2015-06-23 20:01:00 UTC) #1
Ken Russell (switch to Gerrit)
lgtm
5 years, 6 months ago (2015-06-23 20:57:36 UTC) #2
Nate Chapin
public/ lgtm
5 years, 6 months ago (2015-06-23 22:02:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207483004/1
5 years, 6 months ago (2015-06-23 22:28:43 UTC) #5
commit-bot: I haz the power
Exceeded global retry quota
5 years, 6 months ago (2015-06-23 22:37:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207483004/1
5 years, 6 months ago (2015-06-23 22:39:13 UTC) #9
commit-bot: I haz the power
Exceeded global retry quota
5 years, 6 months ago (2015-06-23 22:43:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207483004/1
5 years, 6 months ago (2015-06-24 03:27:00 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60500)
5 years, 6 months ago (2015-06-24 04:35:57 UTC) #15
Zhenyao Mo
Failure is unrelated. Landing with NOTRY=true
5 years, 6 months ago (2015-06-24 04:38:06 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207483004/1
5 years, 6 months ago (2015-06-24 04:38:39 UTC) #18
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 04:42:25 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197702

Powered by Google App Engine
This is Rietveld 408576698