Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Unified Diff: media/blink/skcanvas_video_renderer.cc

Issue 1203793003: Remove flip_y, premultiply_alpha, unmultiply_alpha support in command buffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc ('k') | ppapi/lib/gl/include/GLES2/gl2ext.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/skcanvas_video_renderer.cc
diff --git a/media/blink/skcanvas_video_renderer.cc b/media/blink/skcanvas_video_renderer.cc
index 71d1e77bb3c061a892aadd4063ea922298f7f72c..a61ea3688f0c27e8c9ba92e7c218635e7682c9b2 100644
--- a/media/blink/skcanvas_video_renderer.cc
+++ b/media/blink/skcanvas_video_renderer.cc
@@ -637,17 +637,13 @@ void SkCanvasVideoRenderer::CopyVideoFrameSingleTextureToGLTexture(
// The video is stored in a unmultiplied format, so premultiply
// if necessary.
- gl->PixelStorei(GL_UNPACK_PREMULTIPLY_ALPHA_CHROMIUM, premultiply_alpha);
// Application itself needs to take care of setting the right |flip_y|
// value down to get the expected result.
// "flip_y == true" means to reverse the video orientation while
// "flip_y == false" means to keep the intrinsic orientation.
- gl->PixelStorei(GL_UNPACK_FLIP_Y_CHROMIUM, flip_y);
gl->CopyTextureCHROMIUM(GL_TEXTURE_2D, source_texture, texture,
internal_format, type,
flip_y, premultiply_alpha, false);
- gl->PixelStorei(GL_UNPACK_FLIP_Y_CHROMIUM, false);
- gl->PixelStorei(GL_UNPACK_PREMULTIPLY_ALPHA_CHROMIUM, false);
gl->DeleteTextures(1, &source_texture);
gl->Flush();
« no previous file with comments | « gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc ('k') | ppapi/lib/gl/include/GLES2/gl2ext.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698