extensions/browser/extension_function.cc - Issue 1200503002: [Extensions] Kill off ExtensionMsg_AddMessageToConsole

Unified Diff: extensions/browser/extension_function.cc

Issue 1200503002: [Extensions] Kill off ExtensionMsg_AddMessageToConsole (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/speech/extension_api/tts_engine_extension_api.cc ('K') | « extensions/browser/app_window/app_window.cc ('k') | extensions/browser/suggest_permission_util.h » ('j') | extensions/browser/suggest_permission_util.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/extension_function.cc

diff --git a/extensions/browser/extension_function.cc b/extensions/browser/extension_function.cc

index de84548d44105ea6b23b5d4df41d2b9558c80925..0c0ca29d3c0f95cfb2c65831baa8aad7627d2dea 100644

--- a/extensions/browser/extension_function.cc

+++ b/extensions/browser/extension_function.cc

@@ -479,8 +479,9 @@ void UIThreadExtensionFunction::SetTransferredBlobUUIDs(

void UIThreadExtensionFunction::WriteToConsole(

content::ConsoleMessageLevel level,

const std::string& message) {

- render_frame_host_->Send(new ExtensionMsg_AddMessageToConsole(

- render_frame_host_->GetRoutingID(), level, message));

+ WebContents::FromRenderFrameHost(render_frame_host_)

not at google - send to devlin 2015/06/19 23:14:58 Can you just call render_frame_host_->AddMessageTo

Devlin 2015/06/19 23:53:51 We should only call AddMessageToConsole on the mai

not at google - send to devlin 2015/06/22 17:54:10 Seems like a devtools bug, at least in their API,

Devlin 2015/06/22 19:52:32 Added comment.

+ ->GetMainFrame()

+ ->AddMessageToConsole(level, message);

}

IOThreadExtensionFunction::IOThreadExtensionFunction()