extensions/browser/suggest_permission_util.h - Issue 1200503002: [Extensions] Kill off ExtensionMsg_AddMessageToConsole

Unified Diff: extensions/browser/suggest_permission_util.h

Issue 1200503002: [Extensions] Kill off ExtensionMsg_AddMessageToConsole (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/extension_function.cc ('K') | « extensions/browser/extension_function.cc ('k') | extensions/browser/suggest_permission_util.cc » ('j') | extensions/renderer/console.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/suggest_permission_util.h

diff --git a/extensions/browser/suggest_permission_util.h b/extensions/browser/suggest_permission_util.h

index a10c345691e83b227051dcf92bef88c6d4ad8d83..b7f60d8bed34336fefeda968cdd542aa4f766604 100644

--- a/extensions/browser/suggest_permission_util.h

+++ b/extensions/browser/suggest_permission_util.h

@@ -8,7 +8,7 @@

#include "extensions/common/permissions/api_permission.h"

namespace content {

-class RenderViewHost;

+class WebContents;

}

namespace extensions {

@@ -21,7 +21,7 @@ class Extension;

bool IsExtensionWithPermissionOrSuggestInConsole(

APIPermission::ID permission,

const Extension* extension,

- content::RenderViewHost* host);

+ content::WebContents* web_contents);

not at google - send to devlin 2015/06/19 23:14:58 RenderFrameHost would be more appropriate.

Devlin 2015/06/19 23:53:52 But that means that then callers have to remember

not at google - send to devlin 2015/06/22 17:54:11 I do think that passing in render frame is more co

Devlin 2015/06/22 19:52:32 Changed.

} // namespace extensions