extensions/browser/app_window/app_window.cc - Issue 1200503002: [Extensions] Kill off ExtensionMsg_AddMessageToConsole

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/app_window/app_window.cc

Issue 1200503002: [Extensions] Kill off ExtensionMsg_AddMessageToConsole (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/speech/extension_api/tts_engine_extension_api.cc ('K') | « extensions/browser/app_window/app_web_contents_helper.cc ('k') | extensions/browser/extension_function.cc » ('j') | extensions/browser/extension_function.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/app_window/app_window.cc

diff --git a/extensions/browser/app_window/app_window.cc b/extensions/browser/app_window/app_window.cc

index 77da594a4b06a99309a4374957fc6ef5a0be9570..9c8d8a8ed795630204f9044cf30029194caae28c 100644

--- a/extensions/browser/app_window/app_window.cc

+++ b/extensions/browser/app_window/app_window.cc

@@ -925,8 +925,8 @@ void AppWindow::ToggleFullscreenModeForTab(content::WebContents* source,

if (!extension)

return;

- if (!IsExtensionWithPermissionOrSuggestInConsole(

- APIPermission::kFullscreen, extension, source->GetRenderViewHost())) {

+ if (!IsExtensionWithPermissionOrSuggestInConsole(APIPermission::kFullscreen,

+ extension, source)) {

return;

}