chrome/browser/speech/extension_api/tts_engine_extension_api.cc - Issue 1200503002: [Extensions] Kill off ExtensionMsg_AddMessageToConsole

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/speech/extension_api/tts_engine_extension_api.cc

Issue 1200503002: [Extensions] Kill off ExtensionMsg_AddMessageToConsole (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/mdns/mdns_api.cc ('K') | « chrome/browser/notifications/desktop_notification_service.cc ('k') | chrome/browser/ui/app_list/search/launcher_search/extension_badged_icon_image_unittest.cc » ('j') | extensions/browser/extension_function.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/speech/extension_api/tts_engine_extension_api.cc

diff --git a/chrome/browser/speech/extension_api/tts_engine_extension_api.cc b/chrome/browser/speech/extension_api/tts_engine_extension_api.cc

index 7e4071f516c0efaaf735ac804938cf68cfdfdf3b..d5670808ef74643c910a1f943ba9ac6f9e0409e4 100644

--- a/chrome/browser/speech/extension_api/tts_engine_extension_api.cc

+++ b/chrome/browser/speech/extension_api/tts_engine_extension_api.cc

@@ -17,8 +17,9 @@

#include "chrome/browser/speech/tts_controller.h"

#include "chrome/common/extensions/api/speech/tts_engine_manifest_handler.h"

#include "chrome/common/extensions/extension_constants.h"

+#include "content/public/browser/render_frame_host.h"

#include "content/public/browser/render_process_host.h"

-#include "content/public/browser/render_view_host.h"

+#include "content/public/browser/web_contents.h"

#include "content/public/common/console_message_level.h"

#include "extensions/browser/event_router.h"

#include "extensions/browser/extension_host.h"

@@ -26,7 +27,6 @@

#include "extensions/browser/extension_system.h"

#include "extensions/browser/process_manager.h"

#include "extensions/common/extension.h"

-#include "extensions/common/extension_messages.h"

#include "extensions/common/extension_set.h"

#include "net/base/network_change_notifier.h"

@@ -57,10 +57,9 @@ void WarnIfMissingPauseOrResumeListener(

extensions::ExtensionHost* host =

extensions::ProcessManager::Get(profile)

->GetBackgroundHostForExtension(extension_id);

- host->render_process_host()->Send(new ExtensionMsg_AddMessageToConsole(

- host->render_view_host()->GetRoutingID(),

+ host->host_contents()->GetMainFrame()->AddMessageToConsole(

content::CONSOLE_MESSAGE_LEVEL_WARNING,

- constants::kErrorMissingPauseOrResume));

+ constants::kErrorMissingPauseOrResume);

not at google - send to devlin 2015/06/19 23:14:58 Same here.

Devlin 2015/06/22 19:52:32 This one doesn't even check that the background ho

}

} // namespace